Repository navigation
Conversation
| fields = ["execution_requirements"], | ||
| ) | ||
|
|
||
| def _desugar_action_impl(ctx): |
There was a problem hiding this comment.
I think it would be better to have a higher-level integration test (i.e. using rules_bazel_integration_test), rather than an analysis test for the action itself. In its current state, this test relies on many implementation details surrounding the desugar worker support.
The important scenarios to capture here are before vs after Bazel 10. So if you decide to go forward with my suggestion in test.bzl (i.e. create a new integration test), it would be sufficient to just test against 9.x and 10.x. |
|
It looks like presubmit failed for WORKSPACE support (sorry, we still support this until Bazel 8 deprecation). It might make more sense to create a dedicated task in presubmit.yml for this, where only bzlmod is supported. |
Closes #539.
Desugar always advertises singleplex worker support, so
--persistent_multiplex_android_dex_desugarhas no effect on its actions. This still happens in rules_android 0.8.0.Copy DexBuilder's flag checks from
rules/dex.bzl. Enable workers when the persistent flag is set, then enable multiplex workers when the multiplex flag is also set. Both Java tools already useWorkRequestHandler, which supports multiplex requests.Tests reuse the R8 app fixture and cover all four flag combinations on Bazel 9.2.0 and Bazel 10 (
last_green).