Repository navigation
fix(appautomate): ask native runs for devices as App Automate lists them - #510
Merged
Merged
Conversation
runAppTestsOnBrowserStack validated its devices against App Automate's device
list but then sent the device strings built from the raw input. App Automate
lists Android versions as "14.0", so a run asked for "Google Pixel 8" on "14"
went out as "Google Pixel 8-14": the build started, its session never got a
device, and it errored about an hour later. The tool's own schema example uses
"14".
Espresso and XCUITest runs now send the validated name and version
("Google Pixel 8-14.0"). A run with no devices still sends none.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 22, 2026
Collaborator
|
Review: #510 Correct for the reported bug ( Medium
Low
AI-assisted read-only review of the diff. Items marked (unverified) were not checked against the live APIs. |
…e-device-versions
…run asks for
The run-started answer names the devices the run asks App Automate for, and when a
requested OS version is not listed and the resolver used the closest one, says so, so a
run on another version than asked for is not missed. Non-numeric versions ("latest") are
expected to resolve and are not flagged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…them A validated device's name is optional in its type; the devices note now says so, which fixes the build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Thanks @sarve-shreyas. Addressed the Medium in 61f02c6 and 2c5b5b6:
|
This was referenced Oct 23, 2026
Aaryan430
added a commit
that referenced
this pull request
Oct 23, 2026
Brings in #502 (Automate links, share links, large exports, one-page view, scan-run comparison, #510's device note, #513's scan settings, #492's Ask AI pointer). Conflicts resolved by keeping both sides: - fetchAccessibilityIssues resolves the source first, then compareWith goes to the scan-run comparison for a scan and to the app-build comparison for an app build; pageUrl and exportTaskId pass through for web reports, and the next-page hint keeps the pageUrl with the exact remaining count. - Report links: a share link is unwrapped first, then app and manual-report links, then Automate links. - The CSV parser pages through the shared pageOf/sortBySeverity; its local copy is dropped. - The run-started message carries both the device note and the accessibility guidance. - The ids handoff keeps main's Ask AI pointer within the 200-character budget; the app lists' searchCapability pointer moves to the buildId and appReportId argument descriptions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runAppTestsOnBrowserStackchecks the requested devices against App Automate's device list (validateAppAutomateDevices), but then ignores what that returns and builds the device strings from the raw input.App Automate lists Android versions as
14.0. An Espresso run requested asGoogle Pixel 8on Android14, which is how agents ask and how the tool's own schema example writes it, goes out asGoogle Pixel 8-14. The build starts, its session never gets a device, and it ends inerrorabout an hour later.Seen in an eval run: an Espresso build asked for
Google Pixel 8-14sat queued and errored after 64 minutes. The same app and suite asked forGoogle Pixel 8-14.0ran straight away.Change
Espresso and XCUITest runs send the device name and version the validator resolved (
Google Pixel 8-14.0, App Automate's own display name). A run with no devices still sends none.Verification
"osVersion": "14"went out asGoogle Pixel 8-14.0, and its session started within 10 seconds.14→14.0, a lower-case device name → App Automate's display name, and no devices → none.npm run build(lint, format, 1355 tests, tsc) passes.🤖 Generated with Claude Code
Changes after review (Shreyas)
Summary by CodeRabbit