[topunix]

Bug 1428647: disable BMO-specific extensions

Disables the extensions that only make sense on bugzilla.mozilla.org by adding a 'disabled' marker, per comment 0: BMO, GuidedBugEntry, MozProjectReview, REMO, OrangeFactor, PhabBugz, ZPushNotify, ContributorEngagement.

Kept enabled (generic or depended on by generic extensions): Push (Webhooks depends on it), TrackingFlags (BugModal and BugmailFilter depend on it), Review, UserStory, and the remaining generic extensions. TagNewUsers, Profanivore, Bitly and BzAPI are borderline and left enabled; happy to disable any of them.

Core decoupling required to run without BMO

BMO monkey-patches methods onto core classes in its BEGIN block (Extension.pm lines 89-110), and several core call sites used them unconditionally. Each call site now checks ->can() first, following the same pattern as the secure_mail guard in PR #183:

• Bugzilla/Bug.pm: per-product default hw/os on create; group_always_settable at both call sites. With BMO off, the fallback is exactly upstream behavior (only group_is_settable is checked), so no access is widened.
• enter_bug.cgi: default_platform/default_op_sys. Without this, Enter Bug returned a 500 with BMO disabled.
• Bugzilla/WebService/Product.pm: default_platform, default_op_sys and default_security_group are only included in Product.get output when available.
• extensions/BugModal/lib/WebService.pm and bug_modal/groups.html.tmpl: skip the default security group logic and the "Restrict access" checkbox when there is no default security group.

The alternative would be core default stubs for these methods, with BMO overriding them under no warnings 'redefine'. I went with call-site guards to avoid adding new core API, but can switch if you prefer that approach.

Other fixes uncovered by disabling BMO

• Profanivore used HTML::Tree without importing it (it was only loaded as a side effect of BMO). Added the import; Config.pm already declares the dependency.
• report_invalid_date is thrown by core Bugzilla/Util/DateTime.pm but was only defined in BMO's error hook. Moved the definition into core user-error.html.tmpl.
• WebService/User.pm: avoid an uninitialized warning when phabricator_base_uri is unset.
• The guided-entry links on the core create page pointed at BMO and GuidedBugEntry pages. Moved them into BMO's bug/create/create-end hook so they only appear when BMO is enabled.

Test infrastructure

• scripts/entrypoint.pl: skip generate_bmo_data.pl when BMO is disabled.
• qa/config/generate_test_data.pl: made idempotent for priority/platform values, dropped the BMO-only product columns from the insert (the values passed were always NULL), guarded the security_group_id update, and set useclassification (previously only set by the BMO seed).
• Bugzilla/Test/MockDB.pm: only insert the BMO product columns when they exist.
• t/mock-params.t: use core params instead of PhabBugz params.
• Selenium: BMO-only product form fields are only set when present (test_default_groups, test_edit_products_properties, test_votes); test_bmo_autolinkification and test_bmo_enter_new_bug skip when BMO is disabled.

Results

• Webservice suite: all 25 files pass with PR Bug 1851434: guard secure_mail call for installs without SecureMail extension #183 applied. Without Bug 1851434: guard secure_mail call for installs without SecureMail extension #183, the only failures are the known secure_mail and password strength failures that Bug 1851434: guard secure_mail call for installs without SecureMail extension #183 fixes.
• Unit tests (t/): all pass.
• Selenium: 31 of 38 files pass. Remaining:
  • test_create_user_accounts: known, covered by PR [Bug 1963773][Harmony] login-names separate from email addresses #147.
  • test_bug_edit test 25: asserts a hardcoded group ID that depends on BMO creating extra groups at install.
  • test_show_all_products: asserts BMO's "Enter A Bug" page title.
  • test_edit_products_properties (127), test_flags (150), test_qa_contact (29): one "has been added to the database" assertion each. That text is core, and other tests asserting it pass, so this is a specific path I have not tracked down yet.
  • test_sudo_sessions: all subtests passed, then exited 255 during teardown; passed in earlier runs, likely flaky.

Merge-order notes

• PR Bug 1851434: guard secure_mail call for installs without SecureMail extension #183 also edits qa/config/generate_test_data.pl; whichever lands second may need a rebase.
• Splinter calls BMO attachment methods (can_review, external_redirect, fetch_github_pr_diff). PR Bug 1545443: Remove the Splinter extension #194 removes Splinter; if this lands first, Splinter's review pages will error with BMO disabled.

Not addressed (separate follow-ups if wanted)

• search/search-instant.html.tmpl loads GuidedBugEntry's Mozilla product list and defaults to Firefox. A proper fix needs a rewrite to pull products from the API, which overlaps bug 1472565.
• t/bmo/bounced-emails.t calls BAIL_OUT without importing it, and test_sanity does not wait for the database. Both pre-existing.

[topunix]

Follow-up for the CI failures. The first push added a test_sanity filter that skips tests of extensions with a disabled marker (BMO and PhabBugz have t/ dirs), which fixed the Sanity job. The second push fixes the four Interactive Tests jobs: t/bmo/comments.t now skips itself when BMO is disabled, since it files a bug in the Firefox product, which only BMO's seed creates. All checks are green now.

One question for the CI config: with BMO disabled, the Interactive Tests jobs only run bounced-emails.t (comments.t and passwords.t skip). Should CI also run a BMO-enabled configuration, or should these jobs move to a generic suite? I have not touched ci.yml.

[mrenvoize]

Approving. Changed paths are guarded by can() feature detection, disabled markers are honoured (Install/Util.pm:100, Makefile.PL:340), and moving report_invalid_date into core user-error.html.tmpl:1707 is right. Suggestions (non-blocking): perltidy deviations in Bug.pm, enter_bug.cgi, MockDB.pm and WebService/Product.pm, and an empty if-block in BugModal/lib/WebService.pm.