Repository navigation
Preserve BoxList comments during dotted deletion and sorting - #349
Merged
Merged
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting a BoxList item through a dotted index bypasses comment reindexing, so surviving YAML items inherit the wrong comments. Sorting a list with comments also evaluates the key function twice, which can break stateful keys and misplace comments for false-valued callable keys.
For example, deleting
values["[0]"]from:currently writes
- second # first comment. With this fix, it writes- second # second comment.Route dotted deletion through the normal deletion path and reuse the computed sort order, evaluating each key once. Add regressions for dotted deletion and single evaluation of sort keys.