Skip to content

Cannot read properties of null (reading 'addEventListener') #11677

Closed

Description

@DAcodedBEAT

Expected behavior

addEventListener and removeEventListener should only be callable on valid defined and non-null elements.

Current behavior

TypeError: Cannot read properties of null (reading 'addEventListener')
  at addListener(../../node_modules/chart.js/dist/chart.js:3234:8)
  at createProxyAndListen(../../node_modules/chart.js/dist/chart.js:3360:15)
  at DomPlatform.addEventListener(../../node_modules/chart.js/dist/chart.js:3406:21)
  at _add(../../node_modules/chart.js/dist/chart.js:6216:16)
  at <anonymous>(../../node_modules/chart.js/dist/chart.js:6224:41)
  at each(../../node_modules/chart.js/dist/chunks/helpers.segment.js:56:12)
  at _a.bindUserEvents(../../node_modules/chart.js/dist/chart.js:6224:10)
  at _a.bindEvents(../../node_modules/chart.js/dist/chart.js:6205:10)
  at _a._checkEventBindings(../../node_modules/chart.js/dist/chart.js:5903:12)
  at _a.update(../../node_modules/chart.js/dist/chart.js:5852:10)
  at this._doResize(../../node_modules/chart.js/dist/chart.js:5620:46)
  at sentryWrapped(../../node_modules/@sentry/browser/esm/helpers.js:37:17)

From sentry:

image

Reproducible sample

.

Optional extra steps/info to reproduce

No response

Possible solution

Here is what I am proposing: DAcodedBEAT@8930d19

Context

chart.js version

4.4.1

Browser name and version

Chrome >=120 and Edge >= 120 according to my project's Sentry, but probably many others

Link to your project

No response

Activity

  1. DAcodedBEAT commented on Feb 22, 2024

    @DAcodedBEAT
    ContributorAuthor

    @chartjs sorry for the ping but I want to resolve this. I have asked about it about a month ago, I have provided a solution, and would like your input so I can contribute my fix.

  2. DAcodedBEAT commented on Feb 27, 2024

    @DAcodedBEAT
    ContributorAuthor

    @etimberg / @LeeLenaleee seeing that you are recent contributors, I'm pinging you both about this issue (as per the recommendation from the support discord).

  3. etimberg commented on Feb 27, 2024

    @etimberg
    Member

    @DAcodedBEAT the proposed changes make sense to me if you'd like to send a PR

  4. DAcodedBEAT commented on Feb 27, 2024

    @DAcodedBEAT
    ContributorAuthor

    Thanks @etimberg! I opened #11685 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions