Skip to content

Update pnpm lockfile - #11633

Merged
LeeLenaleee merged 4 commits into
chartjs:masterfrom
LeeLenaleee:update-lockfile
Jan 9, 2024
Merged

LeeLenaleee merged 4 commits into
chartjs:masterfrom
LeeLenaleee:update-lockfile

Conversation

@LeeLenaleee

@LeeLenaleee LeeLenaleee commented Jan 8, 2024 •

Copy link
Copy Markdown
Collaborator

Pnpm changed the lockfile version.
Mr to update it so people can install the codebase again without lockfile changes

resolving: #11627

@etimberg

etimberg commented Jan 8, 2024

Copy link
Copy Markdown
Member

hmmmm, not sure why the CI is unhappy

Comment thread package.json
},
"engines": {
"pnpm": ">=7"
"pnpm": ">=8"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we need to update this too, not too happy about that but looking at the npm stats it seems like the majority of the user base is already on this version
image
image
https://www.npmjs.com/package/pnpm?activeTab=versions

@LeeLenaleee

Copy link
Copy Markdown
Collaborator Author

I think the compressed size fails because it needs to use 2 sepperate versions of pnpm and it does not like that. So it should work in following pr's again. But it is an assumption, couldn't find things about it.

@LeeLenaleee
LeeLenaleee merged commit 072213f into chartjs:master Jan 9, 2024
@LeeLenaleee
LeeLenaleee deleted the update-lockfile branch February 28, 2024 15:58
@LeeLenaleee LeeLenaleee added this to the Version 4.5.0 milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants