Skip to content

feat: add debug flag to skip checksum validation of database - #150

Open
prototaxites wants to merge 2 commits into
chklovski:mainfrom
prototaxites:main
Open

prototaxites wants to merge 2 commits into
chklovski:mainfrom
prototaxites:main

Conversation

@prototaxites

Copy link
Copy Markdown

Hi @chklovski,

Following up on my suggestion here: #140

This PR adds an optional command-line flag (dbg_skip_checksum) to skip checksum validation of the CheckM2 database. This will allow us to use a curated, reduced version of the database for unit testing CheckM2 in CI tests for our pipeline, as running CheckM2 with the full database can be very slow (and also needs to be downloaded each time in a CI run).

Let me know what you think, and hopefully we can add this PR (or a similar one). This is a real blocker for quick pipeline validation on our end!

@chrisgulvik

Copy link
Copy Markdown

Having a mini db (and allowing to skip the checksum test) would also improve your own GH Actions by allowing something more than a --version flag test. It looks like the run test is commented out for now.

@prototaxites

Copy link
Copy Markdown
Author

Just want to drop this information here in case anyone else has trouble with this: it turns out the checksum validation is skipped if the database is loaded by setting the env var CHECKM2DB instead of passing the path as a command-line input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants