Repository navigation
ci: let advanced-features-tests keep an OpenShift cluster on manual runs - #683
Open
VishalJaishankar wants to merge 1 commit into
Open
VishalJaishankar wants to merge 1 commit into
VishalJaishankar wants to merge 1 commit into
Conversation
workflow_dispatch gains three inputs: provider (default all), jobs (default both) and openshift_skip_teardown (default false). Scheduled runs are unchanged. With openshift_skip_teardown the harness already preserves the cluster, but its kubeconfig only existed in the runner's temp dir. The cleanup step now uploads kubeconfig, kubeadmin-password and metadata.json to the private CI debug bucket next to the existing debug files, and prints the commands to fetch and later destroy the cluster. The installer prints the kubeadmin password, which ends up in test_output.log and .openshift_install.log and therefore in the public artifact. Both are redacted before upload on every run. Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We need a long-lived OpenShift cluster to validate operator changes, and this workflow is the only thing that can create one. Today it can only be dispatched as the full Tuesday matrix, and
OPENSHIFT_SKIP_TEARDOWNis hardcoded tofalse.What
Three
workflow_dispatchinputs:provider(default all),jobs(default both),openshift_skip_teardown(default false). Scheduled runs are unchanged.How
if, andOPENSHIFT_SKIP_TEARDOWN. The Go harness already honours the variable; no test code changes.kubeconfig,kubeadmin-passwordandmetadata.jsonare copied to the private CI debug bucket, and the job log prints how to fetch them and how to destroy the cluster later.test_output.logand.openshift_install.loginside the public artifact. Both are now redacted before upload on every run.Verified locally: the credential upload against the real bucket, and the redaction regex against both log formats under GNU and BSD sed.