Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An instance method in a JS/TS base class could appear to call a subclass's static method with the same name, or the reverse, because override dispatch matched names without checking the static flag. JavaScript extraction also omitted that flag, so filtering the synthesized edges alone would leave JS incorrect.
Reuse TypeScript's static-modifier hook for JavaScript, make the native JS/JSX walker emit the same flag, and skip JS/TS override-dispatch pairs whose static flags differ. Missing flags retain their existing instance-method meaning, and same-kind matches remain intact. Other languages retain their existing matching; a Java annotation control protects a real override whose existing static metadata is misleading.
Fixes #2761.
Validation:
0de94978before the fix.npm run buildandgit diff --checkpassed.Existing JavaScript and TypeScript projects should be re-indexed after upgrading, as noted in the changelog. Validation was performed on macOS with Node 22.23.2 and standalone Node 24.19.0.