Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open_new_blocks stores the opening fence length in a uint8_t and clamps it to 255, so a fence of 256 or more backticks is closed by any line of 255 backticks, where the spec and commonmark.js keep the block open. That breaks the commonmark round trip: a code block containing a 300 backtick line followed by <script> is rendered with a 301 backtick fence, and parsing that output back ends the code block at the 300 backtick line and turns the script into a live HTML block. Widen fence_length to int and drop the clamp; the union is still 16 bytes so sizeof(cmark_node) stays at 104, and an api_test case covers the 256/255 case.