Repository navigation
Destroy graphics diagnostic scene windows before shutdown - #1440
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The graphics diagnostic can finish its synthetic scene successfully and then segfault during interpreter shutdown on Ubuntu / Python 3.12. Closing the scene GUI only hides its native windows, leaving their destruction to SIP teardown.
Explicitly destroy the scene GUI while QApplication is alive, after disconnecting diagnostic surface and context observers. Add success and injected-failure regression tests that require both native canvases and their GUI to be destroyed before the child returns, and include them in the real OpenGL CI step.
Validation: both new cases fail before the change and pass afterward; all 12 real OpenGL cases pass with CI’s Python 3.12.13 and locked dependencies. The remaining diagnostic tests report 68 passed and 12 opt-in skips. Lint, formatting, and documentation checks pass (documentation drift checked with the intended changelog edit in a temporary index).
The original runner segfault has not reproduced locally; this fixes the demonstrated cleanup gap, and CI must confirm whether it resolves that crash.