Repository navigation
SystemUI: Keep the display on when a biometric unlock ends a pulse - #1375
Closed
AnkitSavani111 wants to merge 1 commit into
Closed
AnkitSavani111 wants to merge 1 commit into
AnkitSavani111 wants to merge 1 commit into
Conversation
With always-on display off, a screen-off UDFPS unlock starts from a
DOZE_PULSING_WITHOUT_UI pulse. BiometricUnlockController notifies its
listeners (dozing=false) before it calls PowerManager.wakeUp(), so the
pulse ends while wakefulness is still asleep, DozeMachine goes back to
DOZE and DozeScreenState turns the display off. PowerManager turns it on
again right after, and that off/on cycle costs about 500 ms ("Screen on
took 530 ms") before the unlocked screen shows.
Treat a pulse that ends because of a biometric wake and unlock like one
that ends while waking up, and finish dozing without touching the
display state.
Signed-off-by: AnkitSavani111 <ankitmsavani12345@gmail.com>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With always-on display off, a screen-off UDFPS unlock starts from a DOZE_PULSING_WITHOUT_UI pulse. BiometricUnlockController notifies its listeners (dozing=false) before it calls PowerManager.wakeUp(), so the pulse ends while wakefulness is still asleep, DozeMachine goes back to DOZE and DozeScreenState turns the display off. PowerManager turns it on again right after, and that off/on cycle costs about 500 ms ("Screen on took 530 ms") before the unlocked screen shows.
Treat a pulse that ends because of a biometric wake and unlock like one that ends while waking up, and finish dozing without touching the display state.