Repository navigation
fix(keycloak-logs): guard ParseKV to prevent errors on non-audit lines (#1908) - #1993
Open
hrithiksaini99 wants to merge 1 commit into
Open
hrithiksaini99 wants to merge 1 commit into
hrithiksaini99 wants to merge 1 commit into
Conversation
Contributor
|
Hi, Please keep the PR form. Add a non-event [org.*] line to the keycloak-logs test, then regenerate parser.assert. Regards, |
sabban
added
the
waiting-for-user
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1908.
Description
The
KEYCLOAK_LOG_LINEgrok pattern (\[org.*\]) matches any Keycloak logger output, not justorg.keycloak.events. Non-audit lines (such as Infinispan, container lifecycle, thread pool, and cluster log entries) were passed directly toParseKV(), which failed because those lines do not contain key-value pairs, generating errors in logs:This change guards
ParseKVinparsers/s01-parse/inherent-io/keycloak-logs.yamlby checkingevt.Parsed.parsed_message contains "type="before callingParseKV. Because expressions short-circuit, non-audit lines bypassParseKVcompletely while real audit events (type=LOGIN_ERROR, etc.) are parsed as expected without noise or regressions.