Repository navigation
Conversation
Array.validate_write takes any selection __setitem__ takes and returns one ChunkProblem per chunk shape the codec chain rejects, without writing or doing any I/O. A basic selection is checked per distinct shape rather than per chunk, and the check before a chunk-local write shares that enumeration. Assisted-by: ClaudeCode:claude-opus-5-5
d-v-b
force-pushed
the
feat/check-write-chunks
branch
from
November 3, 2026 17:23
f23d84b to
c46e6ef
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Add
Array.validate_writeandAsyncArray.validate_write, which report the chunk shapes in a selection that the array's codecs reject, without writing anything or doing any I/O. They take any selectionArray.__setitem__takes and return onezarr.types.ChunkProblemper rejected chunk shape, naming the kind of problem, the shape, the first selected chunk with that shape, and the codec that rejected it. Only an array whose codecs were validated against a single representative chunk can have problems here; that requires a rectilinear chunk grid, which is experimental, and a codec that does not declare how it changes the grid.An empty result covers codec validation only: a codec that checks a shape only while encoding passes it, the store may be read-only, and unknown field names are not looked up.
Stack
Stacked on zarr-developers#4352 (
fix/codec-chain-validation,ae8ddb181); merge that first._check_chunks_before_writenow shares its chunk enumeration with this method. The changelog fragment carries this fork PR's number and needs renaming if the change lands through a different PR.🤖 Generated with Claude Code