Skip to content

Skip over more lines in diffhunk selection #210

Open

Description

@danvk

The diffhunk selection from #200 is functional but leaves a bit to be desired:

  • Deleted diffhunks show a selection line both above and below the diffhunk (should only be above)
  • When webdiff adds more context (e.g. to enforce minJumpSize), you can select the line where it did this. This looks weird and is non-sensical.
  • Selection on top line is not displayed.
  • It should be possible to select the bottom line.
  • Hitting n at the bottom of the file should advance to the next file.
  • Hitting p at the top of the file should move to the previous file.
  • When you click an up/down arrow to show more context, the "seam" is still selectable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions