Repository navigation
Skip unused Python HTTP client for explicit kernel connections - #1017
Merged
aakash-saravanan-db merged 1 commit intoNov 11, 2026
Merged
Conversation
Signed-off-by: Aakash Saravanan <aakash.saravanan@databricks.com>
aakash-saravanan-db
temporarily deployed
to
azure-prod
November 10, 2026 05:46 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
aakash-saravanan-db
marked this pull request as ready for review
November 10, 2026 22:46
aakash-saravanan-db
temporarily deployed
to
azure-prod
November 10, 2026 22:46 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: 1 Low
Looks good, with one low concern. The kernel path no longer uses the Python HTTP client for anything: auth, feature flags and telemetry are already skipped there, and close(), the proxy telemetry and the Thrift→kernel recovery path all handle None correctly. The tests pin explicit, recovery and cached routes plus the Thrift/SEA controls well.
vuanhphung
approved these changes
Nov 10, 2026
aakash-saravanan-db
enabled auto-merge
November 11, 2026 00:26
aakash-saravanan-db
deleted the
aakash-saravanan/skip-kernel-http-client
branch
November 11, 2026 19:36
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
sql.connect(use_kernel=True)builds a Python HTTP client, including SSL setup, even though the Rust kernel uses its own transport.Skip that unused client for explicit kernel connections and handle its absence during setup. Thrift, legacy SEA and automatic fallback keep their existing client.
In an HTTP-only benchmark with 800 concurrent connections, median connect time fell from 7.291 s to 3.369 s. This was a single-run comparison; warehouse warm/load effects were not isolated.
How is this tested?
Unit tests
1,334 unit tests passed (four skipped), plus eight real-kernel tests covering connection lifecycle and sync/async result reads.
Mypy, Black and
git diff --checkpass.Live TLS/proxy and external-cloud validation was not rerun.
Related Tickets & Documents
RE-17633