Repository navigation
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1965 +/- ##
============================================
+ Coverage 92.43% 92.50% +0.07%
- Complexity 3584 3602 +18
============================================
Files 348 348
Lines 7084 7116 +32
Branches 695 711 +16
============================================
+ Hits 6548 6583 +35
+ Misses 370 369 -1
+ Partials 166 164 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1955.
Fix six existing TOML serialization issues, following up on #1956:
IllegalArgumentException. Error messages include the field path and element index where applicable.nan,inf, and-inf.Literal
"null"strings, empty strings, and empty containers remain valid. Non-null schemas whose fields are all omitted retain their empty table structure, including their positions in arrays of tables.Field suppliers are evaluated once per unique field at each schema occurrence. Relative order is preserved within ordinary assignments and within table fields.
Tests
Added regression tests using a test-scoped TOML parser to verify parsed structure, value types, element counts and order, null handling, and supplier invocation counts.
Verified locally with Java 17:
.\mvnw.cmd -B "-Dtest=TomlTest,TomlSerializationTest" test -PnoGpg— 378 tests passed..\mvnw.cmd -B clean test -PnoGpg— 21,856 tests passed, with no failures, errors, or skipped tests.git diff --check— passed.