Repository navigation
Fix: Report DCO check when compare API fails - #309
Merged
ModeSevenIndustrialSolutions merged 3 commits intoJul 29, 2026
Merged
ModeSevenIndustrialSolutions merged 3 commits into
ModeSevenIndustrialSolutions merged 3 commits into
Conversation
GitHub's compare API can return a 422 when a diff takes too long to generate. That previously happened before any check run was created, leaving required DCO checks stuck pending. Use the pull request commits endpoint for normal PR, rerun, and recheck paths because the app only needs commits. Keep compareCommits for merge group ranges, but report failures through a safety-net DCO check run. On evaluation errors, log the issue and create a completed DCO failure check with retry guidance. If that reporting call fails, log and stop without retrying the safety net. Closes dcoapp#302 Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
|
@tykeal is attempting to deploy a commit to the DCO App Team on Vercel. A member of the Team first needs to authorize it. |
Handle check_run.rerequested with a dedicated path because those payloads do not include a top-level pull_request object. Resolve the full pull request before running DCO so check evaluation has the fields it needs. If a rerequested check run is not associated with a pull request, or if the pull request cannot be fetched, publish a failing diagnostic DCO check instead of crashing or staying silent. Closes dcoapp#305 Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Publish a completed failing DCO check on the merge group SHA when the merge group head ref cannot be parsed or the related pull request cannot be fetched. This prevents required checks from staying pending while the merge queue waits for a result that will never arrive. The diagnostic summaries explain the setup failure and ask maintainers to retry the merge queue entry after confirming the pull request still exists and the DCO app can access it. Refs dcoapp#303 Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
tykeal
force-pushed
the
fix/compare-commits-resilience
branch
from
July 28, 2026 20:22
6f9aae3 to
9b19a86
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
test/index.test.js:416
- Grammar: the test name should use “an” before a vowel sound ("an error status").
test("creates a error status if app has no access to checks", async () => {
ModeSevenIndustrialSolutions
approved these changes
Jul 29, 2026
4 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pulls.listCommitsso no diff is generated.check_run.rerequestednever worked because check-run payloads have no top-levelpull_request. The handler now resolves the PR before checking, and re-runs against superseded commits publish an explicit neutral result.Known limitations:
check_run.pull_requests[0]disambiguation is tracked separately in Check re-run may evaluate the wrong pull request #307.Testing
npm test