Skip to content

Fix: Report DCO check when compare API fails - #309

Merged
ModeSevenIndustrialSolutions merged 3 commits into
dcoapp:mainfrom
tykeal:fix/compare-commits-resilience
Jul 29, 2026
Merged

ModeSevenIndustrialSolutions merged 3 commits into
dcoapp:mainfrom
tykeal:fix/compare-commits-resilience

Conversation

@tykeal

@tykeal tykeal commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Known limitations:

Testing

  • npm test

GitHub's compare API can return a 422 when a diff takes too long to
generate. That previously happened before any check run was created,
leaving required DCO checks stuck pending.

Use the pull request commits endpoint for normal PR, rerun, and recheck
paths because the app only needs commits. Keep compareCommits for merge
group ranges, but report failures through a safety-net DCO check run.

On evaluation errors, log the issue and create a completed DCO failure
check with retry guidance. If that reporting call fails, log and stop
without retrying the safety net.

Closes dcoapp#302

Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
@tykeal
tykeal requested review from a team and Copilot July 28, 2026 20:11
@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

@tykeal is attempting to deploy a commit to the DCO App Team on Vercel.

A member of the Team first needs to authorize it.

This comment was marked as outdated.

tykeal added 2 commits July 28, 2026 13:21
Handle check_run.rerequested with a dedicated path because those
payloads do not include a top-level pull_request object. Resolve the
full pull request before running DCO so check evaluation has the fields
it needs.

If a rerequested check run is not associated with a pull request, or if
the pull request cannot be fetched, publish a failing diagnostic DCO
check instead of crashing or staying silent.

Closes dcoapp#305

Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Publish a completed failing DCO check on the merge group SHA when the
merge group head ref cannot be parsed or the related pull request cannot
be fetched. This prevents required checks from staying pending while the
merge queue waits for a result that will never arrive.

The diagnostic summaries explain the setup failure and ask maintainers
to retry the merge queue entry after confirming the pull request still
exists and the DCO app can access it.

Refs dcoapp#303

Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
Copilot AI review requested due to automatic review settings July 28, 2026 20:22
@tykeal
tykeal force-pushed the fix/compare-commits-resilience branch from 6f9aae3 to 9b19a86 Compare July 28, 2026 20:22
@vercel

vercel Bot commented Jul 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Jul 28, 2026 8:23pm

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

test/index.test.js:416

  • Grammar: the test name should use “an” before a vowel sound ("an error status").
    test("creates a error status if app has no access to checks", async () => {

@ModeSevenIndustrialSolutions
ModeSevenIndustrialSolutions merged commit e695526 into dcoapp:main Jul 29, 2026
6 checks passed
@tykeal
tykeal deleted the fix/compare-commits-resilience branch July 29, 2026 12:34

This branch was successfully deployed

1 active deployment
Preview — 9b19a863 Deployed Jul 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-running the DCO check run does nothing DCO step stuck even though the review comment with a recheck request exists

3 participants