Repository navigation
Cut a family-first particle chain where P1's fold cuts it under two_family_names (#1024) - #1049
Merged
Merged
Conversation
…amily_names (#1024) Under a family-first order with `two_family_names`, `Pérez de la Vega Juan` now reads family 'Pérez de la Vega', given 'Juan', where the particle chain had taken the given name ('de la Vega Juan') and O6 declined a unit counting two words. O6 cuts the first unit after the family as `_fold_reach` cuts P1's family-first run, takes the particles and the one name word they attach to, and lays the rest out by the order. Without the switch, or under the default order, the chain stays whole. On the cached ORCID researchers (seven Spanish-speaking countries), the family box is read right in 1,273 of the 1,577 records whose family holds a particle after its first word, where the base read 2. rules/O6 gains a Then bullet (its Juan de la Vega Rodríguez example moves to it), rules/P2 a bullet, decisions/O6 a dated entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- A test case pinning the cut to the family-first orders, with its recorded negative control (without the order guard `du Ménil Thi Mai` reads family 'Thi Mai'). - rules/O6: a fence row for a conjunction-joined chain, which still moves whole; the lone-particle family taking the cut chain (`Van der Merwe Jan`) under Accepted; the Except's wording. - The release bullet names 2.6.0 through 2.8.0; the decline case is labelled feat(#754), not parity. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rst-chain # Conflicts: # docs/release_log.rst
…rst-chain # Conflicts: # tests/v2/rules_budget.json # tools/differential/corpus_rules.jsonl # tools/differential/snapshot.jsonl
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1024.
Under a family-first order with
two_family_names,Pérez de la Vega Juannow reads family 'Pérez de la Vega', given 'Juan', surname2 'de la Vega'. 2.6.0 through 2.8.0 read family 'Pérez', given 'de la Vega Juan': the particle chain swallowed the given name, and O6 declined a unit that counted two words.Change
_take_second_family_namecuts the first unit after the family where_fold_reachcuts P1's family-first run: the particles and the one name word they attach to. The rest is laid out by the order.Pérez de la Vega Juan Carlos→ given 'Juan', middle 'Carlos' (FAMILY_FIRST); middle 'Juan', given 'Carlos' (FAMILY_FIRST_GIVEN_LAST), asGarcía Márquez Juan Carlosreads.Pérez de la Vega);de la Vega y Santos), which still counts two words.Juan de la Vega Rodríguez(family 'Juan') was this very shape, so it moves there.Measured
The issue's own recipe, run on the cached ORCID researchers: ES, MX, CO, PE, CL, VE and AR, 135,735 records.
Accepted
Van der Merwe Jan, read family-first with the switch, now gives family 'Van der Merwe' (it was 'Van'), with surname2 'der Merwe': one surname read as two. This follows from O6's existing lone-particle clause, and is recorded under its Accepted.Interaction with the #959 PR
That PR counts a hyphenated taken word as one. Once both land,
Pérez de la Vega-Santos Juanwill read given 'Juan' too; today it still reads given 'de la Vega-Santos Juan'.Review
An independent review found:
All are fixed in the second commit.
Checks
Fritz Freiherr und von Barread family_base 'Freiherr und von Bar' rather than 'und'? #939 PR.uv run pytest: 36,089 passed. Ruff and mypy clean.🤖 Generated with Claude Code