Repository navigation
Report a bare I or V ending the given part after a comma (#877) - #1063
Merged
Merged
Conversation
rules/C9 (a one-character suffix word inside a comma part) reads the bare letter behind a name word as the generation, and the comma path never reported the guess that the no-comma 'John Doe V' reports. FEC writes the letter as a middle initial about as often as letter frequency predicts, so a reader hesitates too. assign's given-part walk now emits suffix-or-name there, with the no-comma wording and the middle initial as the reading not taken. The reading is unchanged. AGENTS.md's "a kind is worth adding only if a reader would hesitate" bullet used 'Smith, John V' as a fork nobody hesitates over; it uses 'Smith, John V.' now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…exclusion (#877 review) The reading not taken named the middle for 'Smith, de Mesnil V', where the fold of a never-given particle opening the given part takes a letter into the family; the shared numeral report had the same gap. The exclusion of a letter behind a particle is kept, its reason corrected and stated in rules/C9: the chain decides the field, and the walk cannot name it. The stage header lists the new site. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…native moved Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ointers (comment review) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A run of particles and a connective in front are name words whose
field the report can name ('Smith, John de la Q' reads middle 'de la
Q'), so the letter behind them is reported; rules/C9 says 'a lone
particle' for the exclusion.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
derek73
force-pushed
the
fix/issue-877-comma-letter-report
branch
from
November 5, 2026 03:57
5c61f5d to
bfae56f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #877
What changes
After a family comma, a bare
IorVending the given part behind a name word reads as the generational suffix (rules/C9: a one-character suffix word inside a comma part). The comma path never reported that guess. The comma-lessJohn Doe Valready does.The parse now reports
suffix-or-nameon the letter, with the same wording as the comma-less report. The reading it names as not taken is the middle initial. The reading itself is unchanged: 1.4.0's, and #144's data.Doe, John VVsuffix-or-name, newDOE, JOHN IIsuffix-or-name, newDoe, Jane I MrsMrs, suffixIsuffix-or-name, newDoe, John V.V.Doe, John V, JrVSmith, PSM IPSM ISmith, John vvSmith, Van VVSmith, John de la VVsuffix-or-name, new: a particle run's field is knownWhy report it. FEC writes the bare letter in this slot about as often as letter frequency predicts a middle initial would appear (issue #877 has the counts), while #144's file wrote it as the generation. Nothing in the writing tells the two apart. That passes AGENTS.md's test that a reader would hesitate too. This is a new emission of an existing kind, not a new kind.
Not decided here:
AGENTS.md. The "a kind is worth adding only if a reader would hesitate" bullet used
Smith, John Vas its example of a fork nobody hesitates over. That example contradicted both the code and the data. It now usesSmith, John V..Measured
snapshot.py --local <source> --base <origin/master c6207549>. No field moves anywhere; only reports are added.Fazal H Shah, FCPS I, behind the unlisted credentialFCPS, which is read as the given name)Review
The code review found two problems:
Smith, de Mesnil V, where P1's fold takes the letter into the family). This had already affected the shared numeral report (Smith, de Mesnil VI). Fixed, with rows added to_REVIEW_SHAPES.Because
as_a_middleis shared, the field fix also corrects the reading not taken by S10's numeral report, S8's absorbed-word report and #531's class-member report wherever P1's fold opens the given part. A second review, of the fix commit, ran the project's oracle over 5,987 texts under the three orders: failures fell from 1,722 to 294 and no new failure appeared. The 294 left (Pharm D, and a chain behind a title-particle) fail on master too. A stand-in oracle grid (each reported letter replaced byQ, then the parse checked for whereQlands) now finds 0 wrong of 1,035.The test-coverage and comment reviews added rows for a particle run and a connective in front, which report (the field is known), narrowed rules/C9's exclusion to a lone particle, and tightened the citation comments.
Docs amended: rules/C9, decisions/C9, AGENTS.md, the
_assignstage header and the release log. The suite passes on 3.11 and 3.15.🤖 Generated with Claude Code