Make greenlet working with a pool of Promises #43

Activity

1. developit commented on Oct 1, 2019

   

   developit

   on Oct 1, 2019

   Last edited by developit

   Owner

   More actions

   Hi @epavan - you can't pass Promises to greenlet, because the code that generates the work those promises represent would still just be running on the main thread.

   It's likely you're looking for something more like workerize-loader, which lets you import a module as a Worker:

   // validation-auto.js
   async function validationAuto(chunk, workarea, criteria, test_groups) {
     let validate;
     if (window.Worker) {
       // this special import runs the module and its dependencies in a worker:
       validate = (await import('workerize-loader!./validation-worker')).validate;
     }
     else {
       // if there's no Workers support, we'll just run it all on the main thread:
       validate = (await import('./validation-worker')).validate;
     }
     return validate(chunk, workarea, criteria, test_groups);
   }

   // validation-worker.js
   export function validate(chunk, workarea, criteria, test_groups) {
     const validationPromises = chunk.map(id => {
       return new Promise((resolve, reject) => {
         postWorkareaValidationAuto(workarea, id, criteria, test_groups)
           .then(response => resolve(response))
           .catch(error => reject(error));
       });
     });
     return Promise.all(validationPromises);
   }

   The key with the above is that the code to create the Promises is itself moved into a Worker.
2. developit

   added

   discussion

   questionFurther information is requestedFurther information is requested

   and removed

   discussion

   on Oct 1, 2019
3. Purecaesar commented on Nov 9, 2019

   

   Purecaesar

   on Nov 9, 2019

   Last edited by Purecaesar

   More actions

   @epavan if i understand your problem right. You can use it just like that, because if u are gonna make promisess you have to make it inside the worker.

   const validationAutoWorkerized = greenlet(async (chunk, workarea, criteria, test_groups) => {
    const validationPromises = chunk.map(id => {
       return new Promise((resolve, reject) => {
         postWorkareaValidationAuto(workarea, id, criteria, test_groups)
           .then(response => resolve(response))
           .catch(error => reject(error));
       });
     });
   
     const data = await Promise.all(validationPromises);
     console.log(data);
     return data;
   });
   
   validationAutoWorkerized(chunk, workarea, criteria, test_groups);
   

   👍React with 👍1Reacted by Alex Hoyau