Repository navigation
Consider removing expose(), call() and kill() ? #26
Description
worker.expose = methodName => {
worker[i] = function() {
return worker.call(methodName, [].slice.call(arguments));
};
};Instead methodName parameter should be used:
worker.expose = methodName => {
worker[methodName] = function() {
return worker.call(methodName, [].slice.call(arguments));
};
};Beside that I don't see why the call and expose methods are accessible from outside. (Don't assign to worker at all)
The purpose of the kill method is also not clear for me.
Activity
Fix funny hidden bug #26
developit commentedon Apr 5, 2018
heh -
iwas a mistake, but it still worked for automatic methods because it was usingifrom the outer scope.callandexposeare both exposed because sometimes autogeneration could fail. It might be worth looking into the byte cost for this, though - I'm not sure they are widely used. Kill is just a way to shut down the worker before terminating it, and probably worth applying the same scrutiny as the other two.[-]expose uses closure variable i[/-][+]Consider removing expose(), call() and kill() ?[/+]vano21 commentedon Apr 14, 2018
Is it possible to terminate a worker from the main app and if so how? Calling terminate() or kill() doesn't work. Thanks.
developit commentedon May 11, 2018
terminate() should work.
boblauer commentedon May 11, 2018
A fix for
terminate()not working - #28