External deps #9

Activity

1. developit commented on Jan 13, 2018

   

   developit

   on Jan 13, 2018

   Owner

   More actions

   Yup, that's what workerize-loader is for.

   Alternatively, it would be pretty easy to add { type: 'module' } to the Worker instance here, which would enable ES Module imports in modern browsers.
2. developit

   added

   questionFurther information is requestedFurther information is requested

   enhancementNew feature or requestNew feature or request

   on Jan 13, 2018
3. developit commented on Jan 19, 2018

   

   developit

   on Jan 19, 2018

   Owner

   More actions

   Using ES Modules is now supported in 0.1.5.

   It works like this:

   import workerize from 'workerize';
   
   const worker = workerize(`
     import fetchJson from './fetcher'
   
     export function get(url) {
       return fetchJson(url)
     }
   `, { type: 'module' });
   
   worker.get('./some-url').then( data => {
     console.log('Response: ', data);
   });

   👍React with 👍2Reacted by Meirion Hughes and Jan Baykara

   🎉React with 🎉3Reacted by John Rees, Richard Lopes and Lacy Morrow
4. arizonatribe commented on May 24, 2018

   

   arizonatribe

   on May 24, 2018

   Last edited by arizonatribe

   More actions

   I'm receiving an error when I attempt to implement this feature.

   To troubleshoot, I rolled back to version 0.1.5 and attempted to directly mimic the example code:

   // fetcher
   function fetchJson(url, config = {}) {
       return fetch(url, {
           ...config,
           headers: {
               ...(config.headers || {}),
               'Content-Type': 'application/json'
           }
       }).then(response => response.json())
   }
   
   export default fetchJson
   

   And implementing it in a worker:

   const worker = workerize(`
       import fetchJson from './fetcher'
   
       export function get(url) {
           return fetchJson(url)
       }
   `, {type: 'module'})
   
   worker.get('https://jsonplaceholder.typicode.com/posts/1').then(data => {
       console.log('Response: ', data)
   })
   

   Yields the following error (also logging the worker to the console):

   

   

   Any idea what I'm doing wrong?
5. developit commented on Jun 1, 2018

   

   developit

   on Jun 1, 2018

   Owner

   More actions

   You need to use a browser that supports modules-in-Workers. I believe Chrome Canary would let you try that out.
6. arizonatribe commented on Jun 3, 2018

   

   arizonatribe

   on Jun 3, 2018

   More actions

   So standard Chrome doesn't support it?
7. jpvalenciag commented on Jul 5, 2018

   

   jpvalenciag

   on Jul 5, 2018

   More actions

   @developit I'm trying to implement this but I'm getting an error in Chrome:

   TypeError: Failed to construct 'Worker': Module scripts are not supported on DedicatedWorker yet.

   So yeah, maybe standard Chrome doesn't support this yet. But on Firefox I'm getting a different error:

   SyntaxError: import declarations may only appear at top level of a module

   Do you know what could be causing it? Thanks!