Skip to content

Document TemporalAmount units - #443

Merged
jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-document-java-temporal-apis
Aug 14, 2026
Merged

jonathanpeppers merged 2 commits into
mainfrom
jonathanpeppers-document-java-temporal-apis

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Sources

Validation

  • Parsed docs/xml/Java.Time.Temporal/ITemporalAmount.xml as XML.
  • Confirmed CRLF line endings without bare LF characters.
  • Ran git diff --check.
  • Confirmed the ITemporalAmount.Units documentation has no To be added. placeholders.

Refs #267

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings August 14, 2026 15:00
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto Please review this focused source-backed documentation update.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the generated XML documentation for Java.Time.Temporal.ITemporalAmount.Units to replace placeholder text with real reference documentation aligned with java.time.temporal.TemporalAmount.getUnits().

Changes:

  • Replaced To be added. placeholders with meaningful <summary>, <value>, and <remarks> content for ITemporalAmount.Units.
  • Added an inline HTML reference link to the Android Java documentation for TemporalAmount.getUnits().

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/xml/Java.Time.Temporal/ITemporalAmount.xml

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new Android-derived member documentation omits the repository-required AOSP/CC BY 2.5 attribution paragraph that appears on the type and other documented members. Add the standard attribution after the Java reference link (ITemporalAmount.xml:264).

Refs #267

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 78a2d559-f6b4-4b70-8a79-1b2c9ee5c13c

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prior blocker is fixed and the current documentation matches the platform contract.

@jonathanpeppers
jonathanpeppers merged commit dbb24b5 into main Aug 14, 2026
3 checks passed
@jonathanpeppers
jonathanpeppers deleted the jonathanpeppers-document-java-temporal-apis branch August 14, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants