Repository navigation
Document ValueRange validation - #484
Merged
jonathanpeppers merged 1 commit intoAug 15, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 14, 2026 20:52
jonathanpeppers
enabled auto-merge (squash)
August 14, 2026 20:53
There was a problem hiding this comment.
Pull request overview
Updates the API XML documentation for Java.Time.Temporal.ValueRange to replace placeholders with concrete documentation for the validation-related methods, aligning the generated docs with the Android reference.
Changes:
- Replaced
To be added.placeholders with detailed XML docs forCheckValidIntValue(long, ITemporalField?). - Replaced
To be added.placeholders with detailed XML docs forCheckValidValue(long, ITemporalField?). - Minor whitespace cleanup in the existing attribution text within the type-level remarks.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
@dalexsoto review |
dalexsoto
approved these changes
Aug 15, 2026
dalexsoto
left a comment
dalexsoto
left a comment
Member
There was a problem hiding this comment.
The documented API behavior matches the current contracts; no blocking issues found.
jonathanpeppers
deleted the
jonathanpeppers-document-java-temporal-apis-7cb
branch
August 15, 2026 02:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sources
Validation
Refs #267