Repository navigation
Update targets and permissions - #56513
BillWagner wants to merge 2 commits into
Conversation
Update the targets and permissions for github workflows
There was a problem hiding this comment.
🟢 Approval recommended
The status checker supports the new trigger, and no blocking issues were identified in the permission changes.
No open issues 🎉
What changed in this PR
Updates GitHub Actions triggers and job permissions for documentation build checks and reporting.
Changes:
- Switches the OPS status checker from
pull_request_targettopull_request. - Adds check-write access and expands status permissions for relevant jobs.
| File | Description |
|---|---|
.github/workflows/snippets5000.yml |
Adds checks: write. |
.github/workflows/ops-build-reporter.yml |
Changes status access from read to write. |
.github/workflows/check-for-build-warnings.yml |
Changes the PR trigger and grants check/status write access. |
Review effort: Balanced
There was a problem hiding this comment.
This is okay? Not sure why you're adding add'l perms here since it's already working.
There was a problem hiding this comment.
Good catch. I thought I'd removed that.
| runs-on: windows-2022 | ||
| permissions: | ||
| statuses: write | ||
| checks: write |
There was a problem hiding this comment.
Why is this needed if it's working as-is?
There was a problem hiding this comment.
This is because when it moves from pull-request-target to pull-request, it needs this permission to write a check run result. This enables the snippets 5000 to write checks (as markdownlint does) when the PR is from a fork.
There was a problem hiding this comment.
It's already using pull_request though...
Update the targets and permissions for github workflows
pull-requestinstead ofpull-request-targetchecksandstatuses(and occasionallypull-requests)