Skip to content

docs: fix wording in WebUtility.UrlEncode note - #13298

Open
motsem021 wants to merge 5 commits into
dotnet:mainfrom
motsem021:docs/fix-urlencode-note
Open

motsem021 wants to merge 5 commits into
dotnet:mainfrom
motsem021:docs/fix-urlencode-note

Conversation

@motsem021

@motsem021 motsem021 commented Nov 5, 2026 •

Copy link
Copy Markdown

Summary

  • Updated the note in WebUtility.UrlEncode documentation using the wording requested in the issue.
  • Preserved the existing documentation structure and cross-reference.

Fixes #13297


Internal previews

File Preview link
xml/System.Net/WebUtility.xml Learn preview

Build report

@motsem021
motsem021 requested a review from a team as a code owner November 5, 2026 17:46
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Nov 5, 2026
@motsem021

Copy link
Copy Markdown
Author

@dotnet-policy-service agree

> from both the [URL specification](https://url.spec.whatwg.org/) and URI
> [RFC 3986](https://www.rfc-editor.org/rfc/rfc3986.html#section-3.4).

For example, when embedded in a block of text to be transmitted in a URL, the characters `<` and `>` are encoded as `%3c` and `%3e`.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing (plus) sign to (plus sign), or in query part of URI to in the query part of a URI seems fine.

The rest - only/either, rewording the last sentence - look worse / less accurate to me.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

I used the wording suggested by the issue author in #13297. I understand your concerns about the technical accuracy of the other changes.

Would you prefer that I keep the original wording and only apply the grammatical corrections you mentioned?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've updated the note to keep the original technical meaning and applied the grammatical corrections. Could you please take another look?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also revert any unnecessary formatting changes

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the unnecessary changes. I've reverted them and kept only the suggested corrections. Thanks for your patience and feedback!

- Reverted unnecessary formatting and wording changes.
- Preserved the original technical explanation.
- Kept only the grammatical corrections suggested by the reviewer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Syntax fix for Note

2 participants