Repository navigation
Clarify named pipe impersonation permissions - #13318
Open
jeffhandley wants to merge 1 commit into
Open
jeffhandley wants to merge 1 commit into
jeffhandley wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the named-pipe impersonation documentation update.
No open issues 🎉
What changed in this PR
Clarifies named-pipe impersonation in the .NET API reference, explaining why impersonation alone is not an authorization boundary on Linux and macOS.
Changes:
- Documents Windows thread-scoped impersonation and Linux/macOS process-wide effective user ID changes, with server group identities unchanged.
- Removes broad file-access guarantees and recommends explicit authorization checks for client-supplied paths.
| File | Description |
|---|---|
xml/System.IO.Pipes/NamedPipeServerStream.xml |
Updates impersonation remarks and example guidance with platform-specific behavior and authorization cautions. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Linux and macOS,
RunAsClientchanges the effective user ID without changing the server's group identity, so impersonation alone is not an authorization boundary.Clarify the platform-specific behavior and process-wide user ID change, recommend explicit authorization checks, and caution readers of the client-supplied file path example.
Internal previews
Build report