Repository navigation
Conversation
…ectorData.Abstractions
github-actions
Bot
added
the
area-ai-eval
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1670856&view=codecoverage-tab |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the IsExternalInit compatibility fix.
No open issues 🎉
What changed in this PR
This PR addresses MissingMethodException when consumers compiled against the .NET Standard build of Microsoft.Extensions.VectorData.Abstractions call init setters using the .NET build at runtime.
Changes:
- Forward
IsExternalInitto the runtime type in .NET builds. - Add a .NET-only test verifying that the assembly exposes the forward.
| File | Description |
|---|---|
| test/Libraries/Microsoft.Extensions.VectorData.Abstractions.Tests/TypeForwardingTests.cs | Verifies that IsExternalInit is forwarded to the runtime type. |
| src/Libraries/Microsoft.Extensions.VectorData.Abstractions/TypeForwards.cs | Adds the conditional type forward and explains its compatibility purpose. |
Review effort: Balanced
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1671827&view=codecoverage-tab |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A library compiled for
netstandard2.0that sets aninitproperty of this package, likeVectorStoreMetadata.VectorStoreName, fails on .NET 8 and .NET 9 withMissingMethodException. In thenetstandard2.0build the setter carries theIsExternalInitof this assembly; the application gets thenet8.0build, where it carries the one of the runtime.This comes from CommunityToolkit/AI#87, which removes
net8.0from the providers.Changes
TypeForwardedToforIsExternalInitin the .NET builds.Tests
chromadb/chroma:1.5.9and Milvus without a server. Both failed when the store was created. With the forward andMicrosoft.Bcl.AsyncInterfacesin the provider, Milvus created its store and collection, and Chroma, which also needs the same forward inChromaDotNet.Client, wrote, read, filtered and searched.Microsoft Reviewers: Open in CodeFlow
Not in this PR
Microsoft.Extensions.AI.AbstractionsandMicrosoft.Extensions.AIalso haveinitsetters and both .NET Standard and .NET builds. I did not test them.