Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a version directory exists but the
dotnetexecutable is missing, the scripts report that the SDK or runtime is already installed and never restore the host. Require the host to be a file before taking the already-installed path in both PowerShell and Bash. Preserve Windows Desktop runtime installation, since that package does not includedotnet.exe.Addresses the missing-host case in #552. The version-directory marker checks discussed in #694 remain a separate follow-up: repairing those files also requires changes to the extraction skip logic.
Adds package-detection tests for SDK, .NET runtime, and ASP.NET Core runtime installations with a missing host, a host file, or a same-named directory, plus the missing-version and Windows Desktop cases.
Validation:
dotnet.exe, and retried. The original script reported already installed without restoring the host. The updated script restored it, including with-SkipNonVersionedFiles, anddotnet --list-runtimessucceeded.The full download matrix and native Linux/macOS test runs were not executed locally.