Repository navigation
Add attachment downloads with authenticated binary output - #389
Open
pythonyx135793 wants to merge 5 commits into
Open
pythonyx135793 wants to merge 5 commits into
pythonyx135793 wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #130.
Adds attachment downloads to
rbw get:--rawincludes attachment IDs, filenames and sizes. Downloads accept an exact filename or ID; duplicate filenames need an ID. Output is an explicit path, or--output -for binary stdout. Existing files are left intact.The agent fetches the owning cipher and a fresh attachment URL, uses the current personal/organization and item/file keys, and authenticates the binary data before returning it. It respects the current password-reprompt setting and a lock during download. The vault token is kept off blob requests. Cache saves now publish complete snapshots atomically, fixing a race with automatic sync. Tests cover legacy files, malformed keys/data, cache changes and failed requests as well as normal downloads.
The follow-up also fixes locked-buffer destruction: zeroize the bytes, unlock their memory, then free the allocation. A clone/drop regression covers that lifecycle.
Validation of
6963a224:Project CI passes Linux, macOS and musl tests, the platform builds and docs. Its lint job passes Clippy and formatting, then fails
cargo denyon existing dependency advisories and a yanked spin version. Cargo.toml, Cargo.lock and deny.toml are unchanged from77464d4. Fully clearing that gate needs separate upstream dependency work; the published crypto-bigint fixes do not fit the existing constraints or declared MSRV. No audit exceptions were added here.For the bounty in #130: @nahili, is your $500 offer still available? PayPal, Wise, USDC or another compatible wallet work for me.