Repository navigation
Support organizations and collections in list, add and generate - #390
Closed
lkarlslund wants to merge 1 commit into
Closed
lkarlslund wants to merge 1 commit into
lkarlslund wants to merge 1 commit into
Conversation
- sync stores organization names, collections and each entry's collection ids - rbw list --fields org,collections shows where entries live - rbw add/generate --org NAME --collection NAME create entries inside an organization collection (encrypted with the organization key, created via POST /ciphers/create)
Author
|
Closing in favour of #379, which covers the same org/collection support (and more: filters on get/edit/remove, --set-collection, tests). Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #102.
What
rbw syncnow also stores organization names, the vault's collections (names stay encrypted with the organization key) and each entry's collection ids.rbw list --fields org,collectionsshows which organization and collection(s) an entry belongs to. Both are also included in--rawoutput.rbw addandrbw generateaccept--org NAMEand--collection NAME(repeatable). The entry is encrypted with the organization key and created viaPOST /ciphers/createtogether with its collection ids. Organization and collection names match case-insensitively, and ids are accepted too. If the organization is given without a collection, or a name is unknown, the error lists the available choices.Compatibility
add/generatebehave as before: same personal-key encryption, samePOST /ciphers, and an identical request body (organizationIdis skipped when unset).#[serde(default)], so existing caches load unchanged, and older versions can still read caches written by this one.org,collections) inrbw list --raw.Testing
cargo testandcargo clippypass.list --fields name,org,collectionsshows org and collection names, and a--org/--collectionadd created an entry in the right collection, which decrypted correctly and was removed again.