Repository navigation
fix(build): backport NVIDIA eMudhra trust fix - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Backport the eMudhra compromise fix into the NVIDIA v0.1.2 binaries built by
scripts/build-binaries.ts. After applying the landlock patch, updaterustls-webpkito 0.103.16 andwebpki-roots/webpki-root-certsto 1.0.10 before compiling. All three packages exist in v0.1.2's lockfile.The updates are chained with
&&in an awaited SDK command. A nonzero exit throwsCommandExitError, aborts the build, and reaches the script's existing error handler. Add a short removal comment and one matching README line. The v0.1.2 pin and existing build commands remain unchanged.How I verified it
Used a fresh local clone of NVIDIA/OpenShell v0.1.2 at
6648bd0c290efbc41ba131ee9831ee45cd431f94, without E2B:git clone --depth 1 --branch v0.1.2 https://github.com/NVIDIA/OpenShell.git /tmp/emudhra-fix-r2/OpenShell cd /tmp/emudhra-fix-r2/OpenShell git apply /tmp/emudhra-fix-r2/openshell-e2b/patches/landlock-abi2.patch cargo update -p rustls-webpki --precise 0.103.16 cargo update -p webpki-roots --precise 1.0.10 cargo update -p webpki-root-certs --precise 1.0.10 git diff -- Cargo.lock cargo check --locked -p openshell-supervisor -p openshell-sandboxCargo.lockchanges only the versions and checksums of those three packages: rustls-webpki 0.103.15 -> 0.103.16, webpki-roots 1.0.7 -> 1.0.10, webpki-root-certs 1.0.7 -> 1.0.10. A parsed TOML comparison also confirmed no other package fields or package count changed.cargo check --locked -p openshell-supervisor -p openshell-sandboxpassed with Rust 1.95.0 in 1m 03s. Ran withCARGO_BUILD_JOBS=4; suppliedPROTOCandLD_LIBRARY_PATHfrom protobuf packages unpacked under/tmp/emudhra-fix-r2/protoc, with no system installation. No release build was run.In this repository:
All passed. There is no TypeScript compiler or tsconfig in this repository, so this checks parsing and transpilation without executing the script. No E2B sandboxes, binary builder run, template builds, or publishing were performed.
Residual risk
dist/v0.1.2/.provisioning_evidence.