Repository navigation
Bump Microsoft.OpenApi to 3.11.0 and fix two flaky CI tests - #4632
Merged
Merged
Conversation
Microsoft.OpenApi 3.10.2 validates component keys with a 100 ms regex timeout. A loaded CI runner trips it and fails the test with RegexMatchTimeoutException (microsoft/OpenAPI.NET#3101). Version 3.11.0 carries the fix. Microsoft.OpenApi.Readers moves to 1.6.31. The "elapsed < 5s" check in Run_ABatchFailsLate_RunningSiblingsObserveCancellation flaked on slow Windows runners. The Cancelled count already proves the siblings stopped, so the timing check goes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
![infra-vault-gh-plugin-prod[bot]](https://avatars.githubusercontent.com/u/6764390?s=60&v=4){kind=small}
Contributor
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4632/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Microsoft.OpenApito 3.11.0 andMicrosoft.OpenApi.Readersto 1.6.31, and removes a wall-clock assertion from one batch runner test. Both changes target the two test failures on the Windows job of themainrun for #4630.Affects: API reference, Release notes
Prompt summary: Investigate the failed Windows CI job on
main. Check whether the regex timeout comes from an outdated library, then bump allMicrosoft.OpenApipackages and loosen the 5 second bound in the flaky changelog test.Why
Microsoft.OpenApi3.10.2 validates component keys with a regex that has a 100 ms timeout. On a loaded CI runner it throwsRegexMatchTimeoutException, which failedBuildPropertyList_AllOfUnionWithAMapOnlyBase_StaysAUnionAndKeepsTheMap. Upstream tracks this as microsoft/OpenAPI.NET#3101 and fixed it in #3108, merged after 3.10.2 shipped.Run_ABatchFailsLate_RunningSiblingsObserveCancellationasserted that the run finishes in under 5 seconds. It took 8.7 seconds on a slow Windows runner.What
OpenAPI package versions
Microsoft.OpenApimoves from 3.10.2 to 3.11.0, the release after the upstream fix.Microsoft.OpenApi.Readersmoves from 1.6.30 to 1.6.31, the latest release on its 1.x line.Batch runner test
The elapsed-time assertion is gone. The siblings sleep for 10 seconds unless the runner cancels them, so the existing
probe.Cancelled.Should().Be(3)assertion already proves the cancellation and does not depend on machine speed.Out of scope:
Run_ABatchThrowsLate_RunningSiblingsObserveCancellationhas the same shape but no timing assertion, so it is unchanged. I did not read the 3.11.0 changelog for other behaviour changes. The two affected test projects pass locally.Verify
🤖 Generated with Claude Code