Skip to content

feat(service-registry): add list filters and pages - #575

Merged
uniqueg merged 9 commits into
devfrom
feat/455-service-list-filters
Nov 14, 2026
Merged

uniqueg merged 9 commits into
devfrom
feat/455-service-list-filters

Conversation

@uniqueg

@uniqueg uniqueg commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Summary

Makes ecc-client-ga4gh-service-registry-services usable for apps with role-based row actions (Cloud Registry UI, elixir-cloud-aai/cloud-registry-ui#9 and #10):

  • Filters: type (the registry's /services/types, or else the types of the loaded services), organization and environment (shown only if a service has one), rendered when filter is on. Hidden filters don't apply, so none can get stuck.
  • Search: filters the list that is already loaded instead of fetching it again for every query, and also matches the service URL.
  • Pagination: client-side, with a pageSize property (attribute page-size, default 10; 0 or less shows all services). Shown only when there is more than one page; changing the search or a filter goes back to the first page.
  • Row actions: a rowActions render hook, (service) => unknown, returns a Lit template, a DOM node, a string or nothing for each row, so apps don't need to know the service IDs in advance. The actions-<id> slots stay, so existing apps keep working.
  • Row click: clicking a row fires ecc-service-selected, except clicks on its actions or the organization link (marked data-no-select).
  • Never narrows invisibly: the search query applies only while the search field is shown, and a filter only while shown and with a value still among its options.
  • Organization link: is a link only for http:/https: URLs and opens with noopener,noreferrer (before, any URL was passed to window.open); other URLs show the plain name.
  • Not done: the verified filter. The issue asks for it "once the registry exposes verification", and the Service Registry schema in this package has no such field yet. The docs say so.
  • Tests: this package had none. It now has services.test.ts (36 tests) and a test script on port 8004 (8003 went to the TES tests on dev), using the shared web-test.runner-config.mjs like the cloud-registry package. The component's lifecycle methods (firstUpdated, updated, loadData) are unchanged, to stay out of the way of the provider lifecycle work (fix: react to provider set after the first update #565).
  • Docs: apps/documentation/pages/docs/service-registry/components/services.mdx covers the new properties, the slot and the changed events.

Changeset: .changeset/service-registry-list-filters.md (minor).

Verification

  • npm test in packages/ecc-client-ga4gh-service-registry: 36 passed on Chromium and on Firefox. WebKit didn't run locally because its browser isn't installed on this machine; CI installs it.

  • The new tests were written first and failed against the old component. The regression test for hidden filters failed before its fix.

  • npm run lint at the repo root (all packages, including the docs build): 19/19 tasks passed.

  • tsc on the package: no errors in the sources. Test files aren't type-checked, as in the other packages.

  • CI on ef154ce (before the Sourcery fixes): all checks passed (Lint, Test on Node 22 and 24 incl. WebKit, CI passed, codecov patch/project, CodeQL, Read the Docs).

Maintainer review (anuragxxd)

Addressed in 0fc259a, 50539e5 and 02caa7d, with tests and docs:

  • The data-no-select check stops at the row, so ancestors of the component can't suppress row selection.
  • A missing, empty or invalid page-size falls back to 10; 0 or less still shows all services on one page.
  • Clicks with a modifier key and clicks that end a text selection (a drag on the row) don't fire ecc-service-selected; a selection made before the click (e.g. elsewhere on the page) doesn't block it.

Verification of these commits: npm test in the package, 46 passed on Chromium and Firefox (WebKit not installed locally; CI runs it); npx eslint . 0 errors; the commit hook's turbo run lint (all packages and the docs build) passed. The new tests failed before the fixes.

Declined review findings

From the adversarial-reviewer and quality-reviewer subagents (two rounds; all high and medium findings and the cheap lows are fixed in the third and fourth commits):

  • Share the pagination markup with the other list components / page through the provider like ecc-client-ga4gh-trs tools. Client-side paging is what the issue asks for (the Service Registry API has no paging), and a shared pagination helper would belong in ecc-utils-design, which this PR doesn't touch.
  • Align the default pageSize with tools.ts (5). The packages already differ (TRS and TES 5, WES and DRS 10); 10 suits a registry list.
  • Show the new features in the live docs preview. Optional; the reference sections document them.
  • Sourcery: old or failed type responses after a registry switch (two threads). These are the provider lifecycle (updated, load*), which this PR leaves unchanged; fix: react to provider set after the first update #565 reworks it.
  • Sourcery: same-name organizations share one filter option. The table shows organizations by name only, and the API has no other organization identifier.
  • firstUpdated and updated may load twice for an element initialised with baseUrl. Not changed by this PR (it leaves the lifecycle alone); the provider lifecycle is fix: react to provider set after the first update #565.
  • Adversarial reviewer (round 2, low): the drag check compares the selected text, so dragging the same text again (e.g. two services with the same name) still selects the row. Rare, and the row then does what a plain click does; tracking range identity across shadow roots isn't worth the complexity here.

Open questions

None.

Closes #455

🤖 Generated with Claude Code

uniqueg and others added 4 commits November 13, 2026 07:18
The services list now filters the loaded services by type,
organization and environment, searches them locally (including the
service URL) instead of fetching the list again, and pages them with
a page-size property. A rowActions render hook lets apps add actions
to each row without knowing the service IDs in advance, and clicking
a row selects its service. Adds the package's first tests and its
test script.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A filter selected before it was hidden (filter turned off, or no
service with an environment after a reload) kept narrowing the list
with no way to clear it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Ignore the search query while the search field is hidden, and show
  the query that applies when it is shown again.
- Ignore filter values that are no longer among the options (e.g.
  after a reload from another registry).
- Derive the filter options once per change of the services, in
  willUpdate, with one place that decides which filters apply.
- Open organization links only for http(s) URLs, with noopener.
- Rename the marker for clicks that don't select a row to
  data-no-select.
- Test the default page size, the page links and ellipses, the page
  clamp, null and replaced rowActions, the organization link and the
  load error.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Organization names are rendered as links only for http(s) URLs, so no
link does nothing on click. Tests the type filter's fallback to the
services' types, and adds baseUrl to the documented properties.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer's Guide

API

Expose the row-actions renderer and document the component’s public properties, slots, and selection event contract.

  • packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts L24-27, L81-90, L107-123

Implementation

Add filter option and page-size helpers, apply visible filters and local search, and handle row selection and external URLs safely.

  • packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts L28-75, L129-148, L221-379 (+2 small edits)

UI

Render the filters, paginated service rows, row actions, organization links, and pagination controls.

  • packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts L443-669, L713-716 (+2 small edits)

Configuration

Add the service-registry package test command, reserve its test-runner port, and record the minor changeset.

  • .changeset/service-registry-list-filters.md L1-5
  • packages/ecc-client-ga4gh-service-registry/package.json L41
  • web-test.runner-config.mjs L6-7

Documentation

Document the new filters, local search, pagination, row actions, slots, and selection behavior.

  • apps/documentation/pages/docs/service-registry/components/services.mdx L116-123, L168-172, L187-245 (+4 small edits)

Tests

Add browser tests for search, filters, pagination, row actions, selection, organization links, and load errors.

  • packages/ecc-client-ga4gh-service-registry/src/components/services/tests/services.test.ts L1-742

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@read-the-docs-community

read-the-docs-community Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 cloud-components | 🛠️ Build #35894974 | 📁 Comparing 02caa7d against latest (4655158)

  🔍 Preview build  

1 file changed
± docs/service-registry/components/services/index.html

Resolves the port note in web-test.runner-config.mjs: the TES tests now
use 8003, so the service registry tests move to 8004. Adds the
changeset for the service registry, as dev now uses changesets.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.86192% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.31%. Comparing base (4655158) to head (02caa7d).

Files with missing lines Patch % Lines
...rvice-registry/src/components/services/services.ts 96.86% 14 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #575      +/-   ##
==========================================
+ Coverage   73.53%   75.31%   +1.77%     
==========================================
  Files          33       37       +4     
  Lines        8123     9138    +1015     
  Branches      381      470      +89     
==========================================
+ Hits         5973     6882     +909     
- Misses       2141     2245     +104     
- Partials        9       11       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@uniqueg
uniqueg marked this pull request as ready for review November 13, 2026 09:11
@uniqueg
uniqueg requested a review from anuragxxd as a code owner November 13, 2026 09:11
@sourcery-ai

sourcery-ai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Linked issues

Checked at commit 02caa7d

#455 feat(service-registry): list filters and pagination · 7 of 8 met · 1 to check by hand

# Requirement Status Notes
1 Render type, organization and environment filters. ✅ Met The filters are rendered when filter is on; the environment filter is omitted when no loaded service has an environment.
2 Render a verified filter once the registry exposes verification. 👀 Check by hand (external system) A person must confirm whether the target registry currently exposes verification; the package's Service schema has no verification field, and the change documents that the filter is not available yet.
3 Render client-side pagination with a page-size property. ✅ Met Pagination is applied to the filtered, loaded services; page-size defaults to 10 and 0 or less shows all services on one page.
4 Filter the list that's already loaded instead of fetching it again. ✅ Met Search and the filters operate on the component's loaded services array.
5 Search matches the service URL. ✅ Met The local search includes service.url.
6 Let apps add row actions without knowing service IDs in advance. ✅ Met rowActions renders actions from each service while retaining the actions-<id> slots.
7 Clicking a row selects its service. ✅ Met Row clicks emit ecc-service-selected; clicks on row actions, organization links, modifier keys, or text-selection drags are excluded.
8 An app with role-based row actions can use the list with search, filters and pagination. ✅ Met The component provides local search, the requested filters, pagination, and a per-service row-actions renderer.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 12 issues

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts" line_range="43-44" />
<code_context>
+type FilterOptions = Record<keyof ServiceFilters, FilterOption[]>;
+
+/** The value of a service type in the type filter. */
+const typeKey = (type: ServiceType): string =>
+  `${type.group}:${type.artifact}:${type.version}`;
+
+/** Whether a URL from the registry is a web URL (`http:` or `https:`). */
</code_context>
<issue_to_address>
**Distinct types share one filter**

When different service-type fields contain colons that produce the same joined key, `typeKey` returns the same key for both types, so `computeFilterOptions` deduplicates them and `filterServices` matches both; users see services from both types after selecting one.

Make `typeKey` collision-safe, and use that key consistently when deduplicating options and matching selected types.
</issue_to_address>

### Comment 2
<location path="packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts" line_range="223-224" />
<code_context>
+   * services), and the organizations and environments of the services.
+   */
+  private computeFilterOptions(): FilterOptions {
+    const types = this.serviceTypes.length
+      ? this.serviceTypes
+      : this.services.map((service) => service.type);
+    const uniqueTypes = [
</code_context>
<issue_to_address>
**Old types remain selectable**

When the component switches registries after loading types and the new registry's `getServiceTypes()` request fails, `loadServiceTypes` leaves the previous `serviceTypes` in place, so `computeFilterOptions` uses those instead of the loaded services' types; users can select types that return no services.

Clear `serviceTypes` when the request fails so `computeFilterOptions` falls back to the loaded services.
</issue_to_address>

### Comment 3
<location path="packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts" line_range="223" />
<code_context>
+   * services), and the organizations and environments of the services.
+   */
+  private computeFilterOptions(): FilterOptions {
+    const types = this.serviceTypes.length
+      ? this.serviceTypes
+      : this.services.map((service) => service.type);
</code_context>
<issue_to_address>
**Old registry types replace current options**

When the component switches from registry A to registry B while A’s type request is still pending, a late `getServiceTypes()` response from registry A overwrites `serviceTypes` after the component switches to registry B; `computeFilterOptions()` then prefers A’s non-empty types over B’s loaded services, so B’s types are missing from the filter and selecting them is impossible.

Associate each load with its provider or a request generation and ignore type responses that are no longer current.
</issue_to_address>

### Comment 4
<location path="packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts" line_range="275-276" />
<code_context>
+            service.description,
+            service.url,
+            service.organization.name,
+            service.type.group,
+            service.type.artifact,
+          ].some((field) => field?.toLowerCase().includes(query)))
+    );
</code_context>
<issue_to_address>
**Version searches omit matching services**

When a user searches for a value that occurs only in a service type's version, `filterServices` checks the type group and artifact but not its version, so services with that displayed version are omitted from the results.

Include `service.type.version` among the fields searched by `filterServices`.

Also at `packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts:277`.
</issue_to_address>

### Comment 5
<location path="packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts" line_range="237" />
<code_context>
+        label: `${type.artifact}@${type.version} (${type.group})`,
+      })),
+      organization: asOptions(
+        uniqueSorted(this.services.map((service) => service.organization.name))
+      ),
+      environment: asOptions(
</code_context>
<issue_to_address>
**Same-name organizations cannot be separated**

When the loaded services include distinct organizations with the same name, `computeFilterOptions` deduplicates organizations by name and `filterServices` matches only that name, so selecting the option returns services from both organizations.

Use organization identity, rather than name alone, for organization option values and filtering.

Also at `packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts:266`.
</issue_to_address>

### Comment 6
<location path="packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts" line_range="282" />
<code_context>
-    this.loading = true;
-    this.error = null;
+  private pageCount(total: number): number {
+    if (!(this.pageSize >= 1)) return 1;
+    return Math.max(1, Math.ceil(total / this.pageSize));
+  }
</code_context>
<issue_to_address>
**Invalid page sizes show wrong rows**

When `page-size` is malformed or is set to a positive fractional number, `pageCount` treats `NaN` as one page, and `render` then shows all services; for fractional sizes, `slice` truncates its boundaries and pages overlap or omit services.

Validate that `pageSize` is a finite positive integer before using it to calculate pages or slice services.

Also at `packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts:585-586`.
</issue_to_address>

### Comment 7
<location path="packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts" line_range="494-495" />
<code_context>
+      : html`<ecc-utils-design-button
+          size="sm"
+          @click=${() => this.handleViewDetails(service.id)}
+        >
+          View Details
+        </ecc-utils-design-button>`;
+  }
</code_context>
<issue_to_address>
**Default action still selects service**

When a user clicks the default “View Details” action, the default “View Details” action calls `handleViewDetails`, so clicking an action emits `ecc-service-selected` despite the documented exception for action clicks.

Either stop the default action from emitting `ecc-service-selected`, or document that this action is an exception because it intentionally selects the service.
</issue_to_address>

### Comment 8
<location path="packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts" line_range="24" />
<code_context>
+ * Renders the actions of a row from its service: a Lit template, a DOM node,
+ * a string, or nothing (`null` or `undefined`) for a row without actions.
+ */
+export type RowActionsRenderer = (service: ExternalService) => unknown;
+
+/** The selected values of the filters; empty for "All". */
</code_context>
<issue_to_address>
**Invalid actions crash list rendering**

When a TypeScript caller returns a non-renderable object from `rowActions`, `rowActions` accepts any return value at the type level, and `renderActions` inserts it directly into a Lit child part. If a caller returns a plain object, Lit throws while rendering the row and the services list fails to render.

Type the renderer result as the supported renderable-value union, or validate unsupported values and render a safe fallback.

Also at `packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts:490`.
</issue_to_address>

### Comment 9
<location path="packages/ecc-client-ga4gh-service-registry/src/components/services/tests/services.test.ts" line_range="185" />
<code_context>
+    });
+
+    it("matches the service URL", async () => {
+      const el = await renderLoaded();
+
+      await change(el, searchInput(el), "s3.example.org");
</code_context>
<issue_to_address>
**Registry type source goes untested**

When `getServiceTypes` is skipped or its non-empty result is ignored, `offers the types the registry lists` compares option values that are also present in the default loaded services; the fallback test likewise passes if `getServiceTypes` is never consulted. Ignoring registry-provided types therefore passes both tests.

Use registry types that differ from the loaded services in the registry-types test, and assert the provider method was called in both tests.

Also at `packages/ecc-client-ga4gh-service-registry/src/components/services/tests/services.test.ts:203`.
</issue_to_address>

### Comment 10
<location path="packages/ecc-client-ga4gh-service-registry/src/components/services/tests/services.test.ts" line_range="332-335" />
<code_context>
+        })
+      );
+      await el.updateComplete;
+      await change(el, searchInput(el), "Service s1");
+
+      // s1, s10, s11, s12
+      expect(shownIds(el)).to.deep.equal(["s1", "s10", "s11", "s12"]);
+    });
+
</code_context>
<issue_to_address>
**Page reset is not exercised**

When the page-3 search leaves four matches with a page size of five, `goes back to the first page when the filters change` gets only four matches for `Service s1`, fewer than the page size of five. The render-time page clamp shows those matches even if the search handler fails to reset the page, so the test passes without verifying the reset.

Search for a query that still matches more than five services, then assert that the first five are shown after the change.
</issue_to_address>

### Comment 11
<location path="packages/ecc-client-ga4gh-service-registry/src/components/services/tests/services.test.ts" line_range="462-464" />
<code_context>
+      const el = await renderLoaded();
+
+      setTimeout(() => rows(el)[1].click());
+      const event = (await oneEvent(el, "ecc-service-selected")) as CustomEvent;
+
+      expect(event.detail).to.deep.equal({ serviceId: "s2" });
+    });
+
</code_context>
<issue_to_address>
**Duplicate selection events go unnoticed**

When a row click emits `ecc-service-selected` more than once, `selects a service when its row is clicked` awaits only one `ecc-service-selected` event and checks its detail. If a single row click emits the event twice, `oneEvent` resolves on the first and the test passes without detecting the duplicate.

Spy on the event, click the row, and assert that exactly one event fired with the expected detail.
</issue_to_address>

### Comment 12
<location path="packages/ecc-client-ga4gh-service-registry/src/components/services/tests/services.test.ts" line_range="557-559" />
<code_context>
+        "error not shown"
+      );
+
+      expect(rows(el)).to.have.length(0);
+      expect(root(el).querySelector("ecc-utils-design-pagination")).to.equal(
+        null
+      );
+    });
</code_context>
<issue_to_address>
**Stuck loading state goes unnoticed**

When the load fails, the error is displayed, and the loading state is not cleared, `shows the error if the services can't be loaded` checks `rows(el)`, which selects only rows with `data-service-id`; loading skeleton rows have no such attribute. If an error is shown but `loading` stays true, the test still sees zero rows and no pagination while skeletons remain visible.

Also assert that the skeleton rows are absent after the error is shown, or otherwise wait for and verify that loading has ended.
</issue_to_address>

Sourcery assessment

Approval pending. 12 findings to address first.

Blocking findings: packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts:44, packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts:224, packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts:223, packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts:276, packages/ecc-client-ga4gh-service-registry/src/components/services/services.ts:237, and 7 more


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

- Use a JSON key for service types in the type filter, so that types
  whose fields contain the separator stay apart.
- Search also matches the type version.
- Round a fractional page-size down; treat invalid ones as 0 (all).
- Type rowActions results as the values Lit can render.
- Document that the default "View Details" action selects the service.
- Tighten tests: registry-only types, one selection event per click,
  page reset with more than a page of matches, no skeletons after a
  load error.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@anuragxxd anuragxxd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! A few optional nits:

  • handleRowClick checks data-no-select all the way up to window. Could it stop at the row?
  • A missing or NaN page-size shows all rows. Maybe fall back to 10?
  • Selecting text in a row, or Ctrl-clicking it, fires ecc-service-selected.

uniqueg and others added 3 commits November 14, 2026 18:16
- Check data-no-select only between the click target and the row, so
  an ancestor of the component can't suppress row selection.
- Fall back to 10 services per page for a missing or invalid
  page-size; 0 or less still shows all services on one page.
- Don't select a service for clicks with a modifier key or clicks
  that end a text selection.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Suppress a row click only if the text selection changed since the
mouse button went down on the row (a drag), so that a selection made
before, e.g. elsewhere on the page, doesn't block clicks on buttons,
which keep it. Treat an empty page-size attribute as missing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Clicks without a mousedown on the row, e.g. from code, can't end a
drag, so a text selection doesn't suppress them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@uniqueg

uniqueg commented Nov 14, 2026

Copy link
Copy Markdown
Member Author

Thanks a lot for the review, @anuragxxd! All three nits are addressed, with tests and docs:

  • The data-no-select check now stops at the row, so elements outside it can't suppress row selection.
  • A missing, empty or invalid page-size (e.g. NaN) now falls back to 10; 0 or less still shows all services on one page.
  • Clicks with a modifier key (Ctrl, Cmd, Shift, Alt) and clicks that end a text selection in the row no longer fire ecc-service-selected. A selection made before the click, e.g. elsewhere on the page, doesn't block it.

With your approval in, we're merging now.

@uniqueg
uniqueg merged commit 5961247 into dev Nov 14, 2026
25 checks passed
@uniqueg
uniqueg deleted the feat/455-service-list-filters branch November 14, 2026 18:58
uniqueg added a commit that referenced this pull request Nov 16, 2026
When a load failed, the services, service, tools and objects components
cleared their data without firing their ecc-*-changed event, so the app
kept the data of the previous provider. They now fire it with empty
data. The services list also starts on its first page after a provider
switch, as the TRS and DRS lists do (the list has pages since #575).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(service-registry): list filters and pagination

2 participants