CORS handling seems broken #69
Description
They return only a NetworkError with no more information, EVEN when the response had a 200 status and a correct response.
It happened to me while trying to run the http example locally -> https://guide.elm-lang.org/effects/http.html (only change made was to be able to get the error and print it using Debug.toString)
And also when trying to run the same example but pointing the url to a locally running express endpoint with cors enabled for all urls.
I also tried it with some test api I found on google and that seemed to work correctly. Not sure if Elm is expecting some headers not provided by express by default or is there is something else I should be doing.
Activity
2mol commentedon Jan 8, 2020
same issue as elm/elm-lang.org#829
RenFontes commentedon Jan 8, 2020
By the way, this issue does not happen when using an F# + giraffe + .net core backend.
Not sure if elm was expecting something else not provided by express, but the fact that the request is successful makes me think that it should had been successful for elm too, or that elm should at least give a more descriptive error. (Specially since it prides itself in its descriptive errors)
2mol commentedon Jan 9, 2020
Could you check if your .net core app does a preflight request? You should see one in the networks tab that is OPTIONS instead of GET.
I think elm the language is not doing much wrong here. The good error messages with regards to the compiler don't apply here, since this is a problem that occurs during runtime. But I agree that the Http library could maybe pass more fine-grained information that just NetworkError.
HenkPoley commentedon Jan 21, 2020
Just a slight hint: Under Safari/WebKit the server also needs to respond to the OPTIONS method with the CORS headers. Not only on the GET/POST/PUT/DELETE. This OPTIONS request is silently sent, and can often only be found with a MITM attack on the connection, like Charles Proxy or Fiddler.
turboMaCk commentedon Feb 7, 2025
This is not related to client but to server. Server must response with Allowed Origin to the request. In Express + Elm vs Giraffe + .NET CORE, the difference will be the server component, not the client component. On client there is nothing one can do to bypass security measure other than installing browser plugin or configuring browser. App can't disable security. That would render CORS useless if malicious JS could just disable them.
Probably .NET server automatically enables CORS while with express you need to add middleware to do so.
RenFontes commentedon Feb 20, 2025
I just find it kinda funny that this received a reply in 2025. I had completely forgotten about this. I might try picking elm up again. 😂
2mol commentedon Mar 16, 2025
Ha, the advantage is that it has been very stable, so nothing about elm has changed :)