Intelligent list of paths. #31

Activity

1. rwjblue commented on Jul 31, 2017

   

   rwjblue

   on Jul 31, 2017

   MemberAuthor

   More actions

   @Turbo87 - You 👍 on the general plan laid out above?
2. Turbo87 commented on Jul 31, 2017

   

   Turbo87

   on Jul 31, 2017

   Contributor

   More actions

   in general I'm 👍

   I'm just not sure what the require() stuff is for 🤔
3. rwjblue commented on Jul 31, 2017

   

   rwjblue

   on Jul 31, 2017

   Last edited by rwjblue

   MemberAuthor

   More actions

   Haha, I was just too lazy to write it out manually. For the auto-detect bit, this is basically what I'm proposing:

   const ADDON_PATHS = ['addon', 'addon-test-support', 'tests'];
   const APP_PATHS = ['app', 'tests'];
   
   let paths;
   let package = JSON.parse(fs.readFileSync('package.json'));
   if (package.keywords && package.keywords.indexOf('ember-addon') > -1) {
     // addon
     paths = ADDON_PATHS.slice();
   } else {
     // app
     paths = APP_PATHS.slice();
   }
   
   if (package['ember-addon'] && package['ember-addon'].paths) {
     package['ember-addon'].paths).filter(Boolean);
     package['ember-addon'].paths.forEach(inRepoAddonBasePath => {
       ADDON_PATHS.forEach(addonFolderName => {
         let fullPath = path.join(inRepoAddonBasePath, addonFolderName);
         paths.push(fullPath);
       });
     });
   }
4. Turbo87 commented on Jul 31, 2017

   

   Turbo87

   on Jul 31, 2017

   Contributor

   More actions

   aka. in-repo-addons, right?
5. rwjblue commented on Jul 31, 2017

   

   rwjblue

   on Jul 31, 2017

   MemberAuthor

   More actions

   c
6. rwjblue commented on Jul 31, 2017

   

   rwjblue

   on Jul 31, 2017

   MemberAuthor

   More actions

   currently we auto-process all of lib which isn't guaranteed to be an addon at all (e.g. many addons use lib for node-land code also)
7. cyril-sf commented on Aug 30, 2018

   

   cyril-sf

   on Aug 30, 2018

   Contributor

   More actions

   Is this still needed?