Repository navigation
Fix issues identifying in-repo addon paths in getTelemetryFor. - #129
Merged
Merged
Conversation
With these changes `getModulePathFor` is much more context aware: * when inside an in-repo addon we support transforming `addon` and `addon-test-support` * when inside an app we support trransforming `app` and `test`
rwjblue
force-pushed
the
fixup-get-telemetry-for
branch
from
June 20, 2019 15:11
90beaaf to
6ec165b
Compare
pzuraq
reviewed
Jun 20, 2019
| result = `${moduleNameRoot}/${relativePath}`; | ||
| } | ||
| } else { | ||
| if (relativePath.startsWith('addon-test-support')) { |
Collaborator
There was a problem hiding this comment.
I believe addons could have files in an app/ folder, no? Also, wouldn't this ignore test files in addons?
Collaborator
There was a problem hiding this comment.
Ah, I guess addon files in the app folder are inaccessible anyways - no way to tell if they were part of the app, or the addon 😕
Member
Author
There was a problem hiding this comment.
@pzuraq addon's with files in the app/ folder are super problematic for us, they "appear" as if they are in the app itself (from a module name perspective) so there is no real way to map from lib/some-thing-here/app/foo/bar.js to app-name/foo/bar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes
getModulePathForis much more context aware:addonandaddon-test-supportappandtest