You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Error: Decorating class property failed. Please ensure that proposal-class-properties is enabled and runs after the decorators transform. #447
This error occurs when I'm consuming a V2 addon that has not complied away class properties.
This is incorrect behavior, because
my browsertargets all support class properties
the app has proposal-class-properties, so it should use that
how does this end up working for regular v2 packages? have we always not been able to use class properties?
Is there a way to tell ember-cli-babel to ignore v2 addons? or maybe only run "if it needs to"?
I guess maybe a core_er_ issue is that ember-cli-babel is incorrectly determining that it needs to run on the v2 addons?
Here is a reproduction: NullVoxPopuli/ember-resources#616
this PR demonstrates that by not compiling away properties, you can see from a 5% to 68% reduction in files size (after minification)
the ember app gives this error:
Error: Decorating class property failed.
Please ensure that proposal-class-properties is enabled and runs after the decorators transform.
ah ok, getting context back now -- I saw this in the babel output:
function _initializerWarningHelper(descriptor, context) {
throw new Error('Decorating class property failed. Please ensure that ' + 'proposal-class-properties is enabled and runs after the decorators transform.');
}
Activity
chore(package): add babel plugin
Make all extensions js, and re-add the class properties transform, du…
NullVoxPopuli commentedon Sep 10, 2022
Here is a reproduction: NullVoxPopuli/ember-resources#616
this PR demonstrates that by not compiling away properties, you can see from a 5% to 68% reduction in files size (after minification)
the ember app gives this error:
NullVoxPopuli commentedon Sep 10, 2022
ah ok, getting context back now -- I saw this in the babel output:
how rude