[Tanujkanti4441]

Prerequisites checklist

• I have read the contributing guidelines.

AI acknowledgment

• I did not use AI to generate this PR.
• (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

To add -ms- vendor prefix support to the keyframes selector

What changes did you make? (Give an overview)

Added ms to the vendor prefix list of keyframes matching pattern in no-duplicate-keyframe-selectors.

Related Issues

Is there anything you'd like reviewers to focus on?

Summary by CodeRabbit

• Bug Fixes

  • Duplicate keyframe selectors are now detected in Microsoft-prefixed keyframes, consistent with other supported prefixes.

• Tests

  • Added coverage for valid and duplicate selectors in Microsoft-prefixed keyframes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: eslint/coderabbit/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: a635fa61-cccd-4f9e-8f56-d1c8a7e016a1

---

📥 Commits

Reviewing files that changed from the base of the PR and between 38ac3ad and 6c6de8d.

---

📒 Files selected for processing (2)

• src/rules/no-duplicate-keyframe-selectors.js
• tests/rules/no-duplicate-keyframe-selectors.test.js

---

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

---

---

📝 Walkthrough

Walkthrough

The rule now recognizes -ms-keyframes blocks and applies its existing duplicate-selector checks. Tests cover distinct selectors and a repeated selector.

Changes

Microsoft-prefixed keyframe selectors

Layer / File(s)	Summary
Recognize and test Microsoft-prefixed keyframes src/rules/no-duplicate-keyframe-selectors.js, tests/rules/no-duplicate-keyframe-selectors.test.js	The rule recognizes -ms- keyframe blocks. Tests check that distinct selectors pass and that a repeated 0% selector reports an error on its second occurrence.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: pixel998

---

Merge Risk: ⚪ Minimal · up to 6c6de

The rule now applies its existing duplicate-selector checks to @-ms-keyframes, with tests covering distinct and repeated selectors. No material merge risk is evident.

Pre-merge checks | 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: adding support for the -ms- vendor prefix to keyframe selectors.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

---

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[DMartens]

Changes LGTM, thanks. I agree that we should handle this as a non-breaking bug fix.

[Pixel998]

Is -ms- needed here? IE10 shipped with unprefixed @keyframes, and MDN's compat data doesn't list a -ms- prefix for it.

[DMartens]

There was a preview version of IE 10 which included the prefixed variant (source).
Even though it was no longer supported in IE 10, someone may still have an old CSS file they wish to lint.
In general I think we should support all existing vendor prefixed variants.