Repository navigation
enr-entries/snap.md: add the snap entry - #287
Open
MysticRyuujin wants to merge 1 commit into
Open
MysticRyuujin wants to merge 1 commit into
MysticRyuujin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #286.
Add
enr-entries/snap.md. The entry value is a list of the snap versions that a node serves:[]: snap/1 only. This is the value that go-ethereum writes today, so existing records keep their meaning.[1, 2]: snap/1 and snap/2.[2]: snap/2 only.DNS discovery lists select snap servers by this entry, for example
devp2p nodeset filter -snapand thesnap.*trees of EIP-1459. Before this change, no specification defined the entry, and the entry could not show which versions a node serves. snap/2 (EIP-8189) is not compatible with snap/1, so a node that looks for snap/2 servers needs the version list. The EIP-8189 update in ethereum/EIPs#12493 refers to this format.The spec also says:
Client changes that write this format: