Repository navigation
[build-tools] Disable the git credential helper for the credentialed project repository fetches - #4841
Draft
sswrk wants to merge 1 commit into
Draft
[build-tools] Disable the git credential helper for the credentialed project repository fetches#4841sswrk wants to merge 1 commit into
sswrk wants to merge 1 commit into
Conversation
sswrk
force-pushed
the
szymonswierk/disable-git-credential-helper-for-credentialed-fetches
branch
from
November 9, 2026 14:17
c9e2d96 to
481b35b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4841 +/- ##
==========================================
+ Coverage 77.09% 77.11% +0.02%
==========================================
Files 1118 1118
Lines 56722 56722
Branches 12585 12585
==========================================
+ Hits 43725 43733 +8
+ Misses 12007 12000 -7
+ Partials 990 989 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…project repository fetches
sswrk
force-pushed
the
szymonswierk/disable-git-credential-helper-for-credentialed-fetches
branch
from
November 9, 2026 15:02
481b35b to
0bca8ff
Compare
|
✅ Thank you for adding a changeset! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to the review comment: #4826 (review)
On macOS the git credential helper can keep the repository access even after stripping the token from the origin URL used for repo cloning. If a credential helper such as osxkeychain is configured, git can store that token in the system keychain. This is not happening currently, becuase keychain access is disabled for the worker process.
This PR hardens the clone to not attempt saving anything in the system keychain.
How
Both credentialed fetches in
packages/build-tools/src/common/git.tsnow run with-c credential.helper=. This way git does not hand the token to any helper to store.Test Plan