Repository navigation
Logo: treat a "$" ending a line or the logo as a plain dollar - #2667
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
$at the end of a logo line was treated as the start of a$Ncolor code. The index check failed, the$was printed, and then the newline after it was copied into the line, so the logo lost a line break and the padding of the following lines went off. A$as the very last character also skipped past the terminating\0and kept reading whatever was after the string. Now a$followed by a line end or the end of the logo is printed as a plain dollar and the line end is left to the normal handling.Related issue (required for new logos for new distros)
Fixes #2666
Changes
src/logo/logo.c: in the$handling, a following\n,\ror\0is not consumed.tests/logo.c:ab$\ncdkeeps its line break (height 1, width 3),ab$stops at the terminator (width 3), anda$1b$$cis unchanged.Screenshots
No screenshot; checked through the logo test. Before the fix the same inputs gave height 0 / width 4 for
ab$\ncdand width 5 forab$.Checklist