Repository navigation
feat(identity): add v2 Auth triggers (on_user_created and on_user_deleted) #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9a13f3c
feat(identity): add v2 Auth triggers (on_user_created and on_user_del…
shettyvarun268 529e233
fix(identity): guard raw_factors and raw_provider_data with isinstanc…
shettyvarun268 2d598ad
Merge branch 'main' into shettyvarun268/auth-v2-triggers
shettyvarun268 537ed42
refactor(identity): simplify CloudEvent dict lookups to canonical cam…
shettyvarun268 e35a848
refactor(identity): check only createTime and creationTime in metadata
shettyvarun268 8ea576e
refactor(identity): remove unreachable tenantId CloudEvent attribute …
shettyvarun268 61b1d67
refactor(identity): remove old_value and last_sign_in_time default, c…
shettyvarun268 27e1528
fix(identity): guard fromtimestamp overflow and raise ValueError on n…
shettyvarun268 4867bd3
fix(identity): address PR review feedback on Eventarc/emulator parity…
shettyvarun268 0845bff
chore(identity): remove unused MFA and string customClaims parsing fo…
shettyvarun268 9ea1349
fix(identity): validate metadata timestamps and reject empty tenant_id
shettyvarun268 81b4ad1
refactor(identity_fn): align v2 Auth parser strictly with Eventarc wi…
shettyvarun268 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AuthUserMetadataTimestampsUpdating
AuthUserMetadatafor 2nd-Gen triggers introduces two subtle breaking changes for existing 1st-Gen blocking function users:Type Nullability (
creation_time:datetime->datetime | None):Noneis the right representation because deletion events may omit creation metadata. However, existing blocking function code using strict type checking (mypy/pyright) may raise errors when accessingevent.data.metadata.creation_timewithout aNoneguard.Timezone Awareness (
offset-naive->offset-aware UTC):1st-Gen blocking functions emitted offset-naive datetimes via
utcfromtimestamp()(tzinfo is None). 2nd-Gen triggers emit offset-aware UTC datetimes via_util.timestamp_conversion()(tzinfo=timezone.utc). In Python, subtracting or comparing naive and aware datetimes (e.g.datetime.utcnow() - metadata.creation_time) raisesTypeError: can't compare offset-naive and offset-aware datetimes.Let's make sure both are called out in the PR description under
### ⚠️ Breaking Changesand documented with aBREAKING CHANGE:git footer in the squash commit message. Something like: