Repository navigation
fix(nix): ensure Qt6LinguistTools is available in devShell - #4450
Merged
borgmanJeremy merged 1 commit intoDec 24, 2025
Merged
Conversation
Use inputsFrom to inherit all build dependencies from the package derivation. This ensures the development shell includes qt6.qttools.
Collaborator
|
Thanks! I don't have much opinion on the nix setup so if you say this is better I believe you. |
GCP-TUX
pushed a commit
to GCP-TUX/flameshot
that referenced
this pull request
May 4, 2026
Use inputsFrom to inherit all build dependencies from the package derivation. This ensures the development shell includes qt6.qttools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the nix develop environment was missing Qt6LinguistTools, causing local builds to fail during the configuration step.
Reproduction
On NixOS, executing the following command inside
nix developpreviously resulted in an error:cmake -DCMAKE_BUILD_TYPE:STRING=Debug \ -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE \ -DQT_DEBUG_FIND_PACKAGE:STRING=ON \ --no-warn-unused-cli \ -S . -B buildOutput
Solution
I updated the flake to use
inputsFrominheriting from the mainflameshotpackage derivation.This ensures the development shell automatically includes all build dependencies defined in the package (specifically
qt6.qttoolsin this case), preventing the shell from drifting apart from the actual package build requirements.