Repository navigation
Let the GUI colors be choosen via hex values - #4738
borgmanJeremy merged 5 commits into
Conversation
|
@IndolikarQuantifier |
I have added label for hex text box. |
|
|
||
| void UIcolorEditor::changeInputColor(const QString& hexColor) { | ||
|
|
||
| if(hexColor.contains(QRegularExpression("^#(?:[0-9A-Fa-f]{6}|[0-9A-Fa-f]{8})$"))) { |
There was a problem hiding this comment.
Also the hex values represents RGB and it doesn't contain alpha.
Your regular expression suggests the opposite! You are explicitly allowing a hex value with either 6 OR 8 characters which would be #RRGGBB or #AARRGGBB (A = alpha) 😉
There was a problem hiding this comment.
Oh that's right I have updated the regex so that it will accept only RGB values
There was a problem hiding this comment.
I noticed an issue during my test: If I insert a (valid) hex value into the textbox, the color is not used/applied! For me it is still using the previous color. I think you have to connect to slot UIcolorEditor::updateUIcolor to apply the input.
There was a problem hiding this comment.
resolved this issue
|
Hi @mmahmoudian |
Although @ElTh0r0 kindly approved the PR and I also reviewed it, I believe we still need to hear @borgmanJeremy opinion on the matter. Thanks for your patience. |
|
Once the clang-format failures are addressed we can merge. Thanks for your patience. |
Thansk for review |
|
can you please merge this PR @mmahmoudian @borgmanJeremy |
|
Thank you! |
4 participants
This will add functionality to set color values from hex input.