[lbarrosby]

What this PR does / why we need it:

fluentbit.output.es.logstashFormat is documented in values.yaml as a commented example, but setting it to false has no effect. The template renders it with | default true, and Sprig's default treats false as empty, so the es ClusterOutput always gets logstashFormat: true. That makes it impossible to write to a fixed index (or a data stream) through the chart, since Fluent Bit ignores Index when Logstash_Format is on.

The template now uses dig "logstashFormat" true .Values.fluentbit.output.es, so the default of true still applies when the key is not set, and an explicit false is kept.

Checked with helm template (es output enabled):

• key not set: logstashFormat: true (full render identical to master)
• logstashFormat=true: true
• logstashFormat=false: true on master, false with this change

helm lint charts/fluent-operator passes, and the rendered ClusterOutput validates with kubeconform against the chart's clusteroutputs CRD schema.

Which issue(s) this PR fixes:

None, no issue was open for this.

Does this PR introduced a user-facing change?

Helm chart: fluentbit.output.es.logstashFormat can now be set to false.

Additional documentation, usage docs, etc.:

[joshuabaird]

Thanks, this looks good. I checked it with helm template: an unset key still renders true, and false now comes through as false.

Two small notes, neither blocking:

• An explicit logstashFormat: null now renders an empty value. The field gets dropped and Fluent Bit falls back to its own default (off) instead of the chart's true. That's an unlikely input, so I'm fine leaving it as is.
• The Fluentd Elasticsearch and OpenSearch templates hardcode logstashFormat: true, so Fluentd users can't turn it off either. That would be a good follow-up PR.

[lbarrosby]

Thanks for the detailed review and the follow-up ideas, I sent them as #2114, #2115 and #2118.