Repository navigation
Conversation
The LTSV parser wrote timeKeep as a second Time_Format entry, so timeKeep: true rendered "Time_Format true". Fluent Bit then used "true" as the time format, records failed to parse their time, and Time_Keep was never set. Signed-off-by: Lucas Barros <lucasbarros.kam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Fluent Bit LTSV parser (
LSTV.Params) renderedtimeKeepunder the wrong key:A
ClusterParser/Parserwithltsv: {timeFormat: "%d/%b/%Y:%H:%M:%S %z", timeKeep: true}produced a secondTime_Format trueline instead ofTime_Keep true. Fluent Bit then usestrueas the time format, so the time of every record fails to parse, andTime_Keepis never set. The JSON, logfmt and regex parsers already useTime_Keep; this makes LTSV do the same.Tests:
TestParsers_TimeKeepcovers the four parsers withtimeFormatandtimeKeep: true. On master theltsvcase fails.go test ./apis/...passes,golangci-lint runon the package reports no issues.Which issue(s) this PR fixes:
None, found while reading the code.
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: