optimize _updateLocalClasses in Inspector Service #4393

Activity

1. CoderDake

   added

   P5

   on Aug 19, 2022
2. CoderDake

   changed the title [-]optimize isLocalClass in Inspector Service[/-] [+]optimize `_updateLocalClasses` in Inspector Service[/+] on Aug 19, 2022
3. CoderDake commented on Aug 19, 2022

   

   CoderDake

   on Aug 19, 2022

   Last edited by CoderDake

   ContributorAuthor

   More actions

   Ben recommends

   final isolate = inspectorLibrary.isolate!;
   final futures = <Future>[];
   for (final libraryRef in isolate.libraries!) {
     if (isLocalUri(libraryRef.uri!)) {
       final future = inspectorLibrary.service.getObject(
           isolate.id!, libraryRef.id!
         ).then((result) {
           final library = result as Library;
           for (final classRef in library.classes!) {
             localClasses[classRef.name!] = classRef;
           }
         });
       futures.add(future);
     }
   }
   await Future.wait(futures);
   

   as a temporary measure, although we may still need to find a batch approach long term
   https://github.com/flutter/devtools/pull/4394/files#r950499503
4. kenzieschmoll

   added

   P3issues we think are valid but not importantissues we think are valid but not important

   and removed

   P5

   on Jul 5, 2023
5. johnpryan commented on Oct 22, 2026

   

   johnpryan

   on Oct 22, 2026

   Last edited by johnpryan

   Contributor

   More actions

   It looks like _updateLocalClasses and the associated rootPackages logic in InspectorService were removed in #7175, so this optimization is no longer applicable.
6. johnpryan

   closed this as not plannedon Oct 22, 2026