Skip to content

[transition_overlay] Migrate to cupertino_ui - #245

Open
pjkammer wants to merge 2 commits into
flutter:mainfrom
pjkammer:transition-overlay-cupertino-ui
Open

pjkammer wants to merge 2 commits into
flutter:mainfrom
pjkammer:transition-overlay-cupertino-ui

Conversation

@pjkammer

@pjkammer pjkammer commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Migrates transition_overlay from package:flutter/cupertino.dart to package:cupertino_ui/cupertino_ui.dart, the new location of the Cupertino widgets.

Commits, both unmodified tool output:

  1. Add the dependency. flutter pub add cupertino_ui, which adds cupertino_ui: ^1.1.4.
  2. Switch the imports. dart fix --apply --code=migrate_design_widgets switches the five files that use Cupertino widgets.

The recordings below replay the same taps on main and with this PR:

BeforeAfter
transition_overlay_after.mp4
transition_overlay_cupertino_ui_after.mp4

Tested with Flutter 3.47.7: flutter analyze, flutter test and dart format are clean, no package:flutter/cupertino.dart import is left, and an iOS build changes no tracked files.

Part of flutter/flutter#172942

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
    No new tests: the change is tool output that switches imports, and the existing smoke tests pass unchanged.
  • All existing and new tests are passing.
    Locally, flutter test passes (2 tests).

If you need help, consider asking for advice on the #hackers-new channel on Discord.

cupertino_ui is the new location of the Cupertino widgets. The imports
switch on a subsequent commit.

Generated with `flutter pub add cupertino_ui` (Flutter 3.47.7), which
added cupertino_ui ^1.1.4. That version needs Flutter 3.47.0 or later,
and the lock now records it.
Generated with this command (Dart 3.13.5):

dart fix --apply --code=migrate_design_widgets

It switches the five files that use Cupertino widgets. The two
providers and the smoke test already import widgets.dart. The lint
isn't enabled in this app; --code turns it on for this run. The imports
were already sorted, so no other change was needed.
@pjkammer
pjkammer force-pushed the transition-overlay-cupertino-ui branch from 2a703c5 to d1c0d0a Compare October 28, 2026 22:18
@pjkammer
pjkammer marked this pull request as ready for review October 28, 2026 23:03
@pjkammer
pjkammer requested a review from Piinks October 28, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant